Opened 7 years ago

Closed 7 years ago

#12735 closed defect (duplicate)

doctest framework bug that was somehow observed via -- "optional magma doctest fails on sage-5.0.beta9"

Reported by: mariah Owned by: mvngu
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: doctest coverage Keywords: sd40.5
Cc: robertwb, mhansen, was Merged in:
Authors: Reviewers: William Stein, Mike Hansen
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The following optional magma doctest fails on sage-5.0.bata9 using magma-2.18-4.

eno% ./sage -t -only-optional=magma "devel/sage/sage/symbolic/integration/integral.py"
sage -t -only-optional=magma "devel/sage/sage/symbolic/integration/integral.py"
Traceback (most recent call last):
  File "/home/mariah/sage/sage-5.0.beta9-x86_64-Linux-core2-fc/local/bin/sage-doctest", line 924, in <module>
    test_file(argv[1], library_code = library_code)
  File "/home/mariah/sage/sage-5.0.beta9-x86_64-Linux-core2-fc/local/bin/sage-doctest", line 721, in test_file
    s = extract_doc(file, library_code=library_code)
  File "/home/mariah/sage/sage-5.0.beta9-x86_64-Linux-core2-fc/local/bin/sage-doctest", line 551, in extract_doc
    doc = doc_preparse(F[i:j+3])
  File "/home/mariah/sage/sage-5.0.beta9-x86_64-Linux-core2-fc/local/bin/sage-doctest", line 370, in doc_preparse
    v = [i for i in range(len(t)) if only_optional_include(comment_modifiers[i])]
IndexError: list index out of range
         [0.2 s]
 
----------------------------------------------------------------------
The following tests failed:


        sage -t -only-optional=magma "devel/sage/sage/symbolic/integration/integral.py" # File not found

Fixed by #12493.

Change History (11)

comment:1 Changed 7 years ago by mhansen

Is this reproducible? It seems like more of a problem with sage-doctest than anything specific to Magma.

comment:2 Changed 7 years ago by mhansen

  • Keywords sd40.5 added

comment:3 Changed 7 years ago by was

  • Component changed from interfaces to doctest
  • Owner changed from was to mvngu
  • Summary changed from optional magma doctest fails on sage-5.0.beta9 to doctest framework bug that was somehow observed via -- "optional magma doctest fails on sage-5.0.beta9"

mhansen -- you are right -- this has nothing to do with Magma, a priori. I'll change the title of the ticket. It's a bug in the doctest framework, but I don't yet know how to trigger it. I just looked through the relevant code in sage-doctest, and it's a mix of code I wrote and then later Robert Bradshaw extended with a "tolerance" ability. My code assumes that the lists t and comment_modifiers have the same length, but I think Robert's doesn't and in some cases adds things to t but not comment_modifiers.

comment:4 Changed 7 years ago by was

  • Cc robertwb mhansen was added

comment:5 Changed 7 years ago by was

  • Resolution set to duplicate
  • Status changed from new to closed

This has been fixed in sage-5.0 already as #12493. I'm closing this as a dup.

comment:6 Changed 7 years ago by was

  • Resolution duplicate deleted
  • Reviewers set to William Stein, Mike Hansen
  • Status changed from closed to new

comment:7 Changed 7 years ago by was

  • Status changed from new to needs_review

comment:8 Changed 7 years ago by was

  • Status changed from needs_review to positive_review

comment:9 Changed 7 years ago by was

This should be closed as a dup.

comment:10 Changed 7 years ago by was

  • Milestone changed from sage-5.1 to sage-duplicate/invalid/wontfix

comment:11 Changed 7 years ago by jdemeyer

  • Description modified (diff)
  • Resolution set to duplicate
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.