Opened 9 years ago

Closed 9 years ago

#12727 closed defect (fixed)

AA minpoly bug

Reported by: was Owned by: AlexGhitza
Priority: minor Milestone: sage-5.0
Component: basic arithmetic Keywords:
Cc: Merged in: sage-5.0.beta11
Authors: William Stein Reviewers: David Loeffler
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

| Sage Version 4.8, Release Date: 2012-01-20                         |
| Type notebook() for the GUI, and license() for information.        |
----------------------------------------------------------------------
sage: m=sqrt(sin(pi/5))
sage: m.minpoly() # works
x^8 - 5/4*x^4 + 5/16
sage: QQbar(m).minpoly() # works
x^8 - 5/4*x^4 + 5/16
sage: AA(m).minpoly() # does not work
 ...
 <snip>
 ...
TypeError: Unable to convert number to real interval.

Reported by Håkan Granath on sage-support on March 22, 2012.

Attachments (2)

trac_12727.patch (1.9 KB) - added by was 9 years ago.
trac_12727-whitespace-removed.patch (1.9 KB) - added by davidloeffler 9 years ago.
William's patch but with whitespace removed

Download all attachments as: .zip

Change History (8)

comment:1 Changed 9 years ago by was

  • Status changed from new to needs_review

comment:2 Changed 9 years ago by davidloeffler

Looks good to me, and passes tests on the new beta. (I've just spent a whole day of my life doctesting this module -- see #12662 -- so I feel confident to pass judgement on patches to it.)

comment:3 Changed 9 years ago by davidloeffler

  • Authors set to William Stein
  • Reviewers set to David Loeffler
  • Status changed from needs_review to positive_review

comment:4 Changed 9 years ago by hivert

This is far from being critical but

Verify that Trac #12727 is fixed:: 

could be better written as

Verify that :trac:`12727` is fixed:: 

which setup the link !

Florent

Changed 9 years ago by was

Changed 9 years ago by davidloeffler

William's patch but with whitespace removed

comment:5 Changed 9 years ago by davidloeffler

Apply trac_12727-whitespace-removed.patch

William's patch had trailing whitespace on one line, which the patchbot didn't like. Other than that it's fine -- I extend my positive review to this new patch.

comment:6 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta11
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.