Opened 8 years ago

Closed 8 years ago

#12723 closed enhancement (wontfix)

Update python spkg to add a feature to python's doctest module

Reported by: roed Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords: sd40.5
Cc: jhpalmieri Merged in:
Authors: Reviewers: Volker Braun, David Roe
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by vbraun)

The code at #12415 needs to change Python's doctest module

This ticket can be closed as wontfix.

Attachments (1)

python-2.7.2.p5_review.patch​ (2.4 KB) - added by roed 8 years ago.

Download all attachments as: .zip

Change History (10)

Changed 8 years ago by roed

comment:1 Changed 8 years ago by roed

I posted a diff of python-2.7.2.p5 against python-2.7.2.p4 as an attachment. The actual spkg is available ​ here.

Unfortunately it doesn't succeed in installing, and I don't understand why. I get 

patching file Lib/distutils/command/sdist.py
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file Lib/distutils/command/sdist.py.rej
Error: Patch "../patches/Lib.distutils.command.sdist.patch" failed to apply.

But I didn't touch that patch.... Help would be appreciated, since I haven't updated spkgs very often.

comment:2 Changed 8 years ago by roed

  • Cc jhpalmieri added

comment:3 Changed 8 years ago by mhansen

Is it not possible to modify test.globs before it's run instead of patching Python?

comment:4 Changed 8 years ago by vbraun

  • Authors set to David Roe
  • Keywords sd40.5 added
  • Reviewers set to Volker Braun
  • Status changed from new to needs_review

David will move the doctest.py into the sage library and embrace & extend it there.

Ticket can be closed.

comment:5 Changed 8 years ago by vbraun

  • Status changed from needs_review to positive_review

comment:6 Changed 8 years ago by jdemeyer

  • Dependencies set to #13013
  • Status changed from positive_review to needs_work

Upgrading a spkg requires posting a new .spkg file, not just a patch. Also, this should be rebased to #13013.

comment:7 Changed 8 years ago by vbraun

  • Description modified (diff)
  • Status changed from needs_work to positive_review

No changes necessary. This ticket can be closed as wontfix.

comment:8 Changed 8 years ago by vbraun

  • Milestone changed from sage-5.1 to sage-duplicate/invalid/wontfix

comment:9 Changed 8 years ago by jdemeyer

  • Authors David Roe deleted
  • Dependencies #13013 deleted
  • Resolution set to wontfix
  • Reviewers changed from Volker Braun to Volker Braun, David Roe
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.