Opened 11 years ago

Closed 11 years ago

#12723 closed enhancement (wontfix)

Update python spkg to add a feature to python's doctest module

Reported by: David Roe Owned by: tbd
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords: sd40.5
Cc: John Palmieri Merged in:
Authors: Reviewers: Volker Braun, David Roe
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Volker Braun)

The code at #12415 needs to change Python's doctest module

This ticket can be closed as wontfix.

Attachments (1)

python-2.7.2.p5_review.patch​ (2.4 KB) - added by David Roe 11 years ago.

Download all attachments as: .zip

Change History (10)

Changed 11 years ago by David Roe

Attachment: python-2.7.2.p5_review.patch​ added

comment:1 Changed 11 years ago by David Roe

I posted a diff of python-2.7.2.p5 against python-2.7.2.p4 as an attachment. The actual spkg is available ​ here.

Unfortunately it doesn't succeed in installing, and I don't understand why. I get 

patching file Lib/distutils/command/sdist.py
Reversed (or previously applied) patch detected!  Assume -R? [n] 
Apply anyway? [n] 
Skipping patch.
2 out of 2 hunks ignored -- saving rejects to file Lib/distutils/command/sdist.py.rej
Error: Patch "../patches/Lib.distutils.command.sdist.patch" failed to apply.

But I didn't touch that patch.... Help would be appreciated, since I haven't updated spkgs very often.

comment:2 Changed 11 years ago by David Roe

Cc: John Palmieri added

comment:3 Changed 11 years ago by Mike Hansen

Is it not possible to modify test.globs before it's run instead of patching Python?

comment:4 Changed 11 years ago by Volker Braun

Authors: → David Roe
Keywords: sd40.5 added
Reviewers: → Volker Braun
Status: new → needs_review

David will move the doctest.py into the sage library and embrace & extend it there.

Ticket can be closed.

comment:5 Changed 11 years ago by Volker Braun

Status: needs_review → positive_review

comment:6 Changed 11 years ago by Jeroen Demeyer

Dependencies: → #13013
Status: positive_review → needs_work

Upgrading a spkg requires posting a new .spkg file, not just a patch. Also, this should be rebased to #13013.

comment:7 Changed 11 years ago by Volker Braun

Description: modified (diff)
Status: needs_work → positive_review

No changes necessary. This ticket can be closed as wontfix.

comment:8 Changed 11 years ago by Volker Braun

Milestone: sage-5.1 → sage-duplicate/invalid/wontfix

comment:9 Changed 11 years ago by Jeroen Demeyer

Authors: David Roe
Dependencies: #13013
Resolution: → wontfix
Reviewers: Volker Braun → Volker Braun, David Roe
Status: positive_review → closed
Note: See TracTickets for help on using tickets.