Opened 5 years ago

Closed 5 years ago

#12717 closed defect (fixed)

Add \NN to standard latex constant, fixes a few glitches in LaTeX/HTML output

Reported by: hivert Owned by: hivert
Priority: major Milestone: sage-5.0
Component: documentation Keywords: latex html
Cc: Merged in: sage-5.0.beta14
Authors: Florent Hivert Reviewers: Nicolas M. Thiéry
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The patch

  • add \NN for Natural or Non Negative Integer to standard latex constants
  • add sage/misc/html.py to the documentation and fixes a few wrong ReST markup in it
  • improve the LaTeX printing of builtin constants.
  • fixes a few broken links in sage/misc/html.py and sage/misc/latex.py

Apply : trac_12717-latex_builtin_constants-fh.patch​

Florent

Attachments (1)

trac_12717-latex_builtin_constants-fh.patch​ (9.4 KB) - added by hivert 5 years ago.

Download all attachments as: .zip

Change History (21)

comment:1 Changed 5 years ago by hivert

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 follow-up: Changed 5 years ago by roed

Should I delete the 12697 patch?

comment:3 in reply to: ↑ 2 Changed 5 years ago by hivert

Replying to roed:

Should I delete the 12697 patch?

Yes please !

Florent

comment:4 Changed 5 years ago by hivert

Also the patch you uploaded is directly out of an hg server and was not properly exported. Is it a problem for Jeroen ?

Florent

comment:5 Changed 5 years ago by roed

It's probably better if it were exported. I would wait to get this reviewed and then worry about it if you're still not able to upload the patch to this ticket.

comment:6 Changed 5 years ago by nthiery

For the record, I went through the patch, and it looks good. But I haven't double checked the code changes to the html class, nor recompiled the documentation or run the tests.

comment:7 follow-up: Changed 5 years ago by jdemeyer

Why cannot you upload the patch???

comment:8 in reply to: ↑ 7 Changed 5 years ago by hivert

Replying to jdemeyer:

Why cannot you upload the patch???

No Idea ! I tried to upload some other patch without problem but on this one the trac server seems to hang. It happens with Firefox, Opera and Konqueror. So this shouldn't be a problem related to the browser.

Florent

comment:9 follow-up: Changed 5 years ago by jdemeyer

  • Status changed from needs_review to needs_work

It's not a proper HG exported patch, that's probably why Trac refuses it. Create your patch with hg export and try uploading it again.

comment:10 in reply to: ↑ 9 ; follow-up: Changed 5 years ago by hivert

  • Status changed from needs_work to needs_review

Replying to jdemeyer:

It's not a proper HG exported patch, that's probably why Trac refuses it. Create your patch with hg export and try uploading it again.

No this is not the problem: as I said on sage-devel the exported patch is at

​http://sage.math.washington.edu/home/wstein/www/home/hivert/trac_12717-latex_builtin_constants-fh.patch

I can't manage to get it on trac.

comment:11 Changed 5 years ago by hivert

  • Description modified (diff)

comment:12 in reply to: ↑ 10 ; follow-up: Changed 5 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Replying to hivert:

I can't manage to get it on trac.

There is something wrong with that file. Try to figure out what.

Changed 5 years ago by hivert

comment:13 Changed 5 years ago by hivert

  • Description modified (diff)
  • Status changed from needs_work to needs_review

comment:14 in reply to: ↑ 12 Changed 5 years ago by hivert

Replying to jdemeyer:

There is something wrong with that file. Try to figure out what.

For some reason trac just accepted the exact same file... Whatever !!!

comment:15 Changed 5 years ago by hivert

  • Description modified (diff)

comment:16 Changed 5 years ago by nthiery

  • Reviewers set to Nicolas M. Thiéry
  • Status changed from needs_review to positive_review

comment:17 Changed 5 years ago by jdemeyer

  • Summary changed from Add \NN to standard latex constant, fixes a few glitches in LaTeX/HTML outpu to Add \NN to standard latex constant, fixes a few glitches in LaTeX/HTML output

comment:18 follow-up: Changed 5 years ago by jdemeyer

  • Description modified (diff)

comment:19 in reply to: ↑ 18 Changed 5 years ago by hivert

Replying to jdemeyer:

Thanks for the fix. Concerning the title, it was cut automatically by trac (or so it seems to me). Did something change on trac's config ?

comment:20 Changed 5 years ago by jdemeyer

  • Merged in set to sage-5.0.beta14
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.