Opened 11 years ago

Closed 9 years ago

#12699 closed defect (wontfix)

Stopgap for 9505

Reported by: Jennifer Balakrishnan Owned by: Burcin Erocal
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: symbolics Keywords: rd2
Cc: Volker Braun Merged in:
Authors: Reviewers: Travis Scrimshaw
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by R. Andrew Ohana)

need to use sage.misc.stopgap instead of sage.misc.misc

Attachments (1)

trac_12699.2.patch (816 bytes) - added by Jennifer Balakrishnan 11 years ago.

Download all attachments as: .zip

Change History (15)

comment:1 Changed 11 years ago by Jennifer Balakrishnan

Priority: criticalblocker

comment:2 Changed 11 years ago by R. Andrew Ohana

Authors: Jen Balakrishnan
Description: modified (diff)
Reviewers: R. Andrew Ohana
Status: newneeds_review

comment:3 Changed 11 years ago by R. Andrew Ohana

Status: needs_reviewneeds_work

comment:4 Changed 11 years ago by Jennifer Balakrishnan

Status: needs_workneeds_review

Updated patch to import from sage.misc.stopgap.

comment:5 Changed 11 years ago by Jennifer Balakrishnan

Authors: Jen BalakrishnanJennifer Balakrishnan

comment:6 Changed 11 years ago by R. Andrew Ohana

Status: needs_reviewpositive_review

looks good now

comment:7 Changed 11 years ago by Jeroen Demeyer

Could you write a proper commit message? "Trac 12692" isn't. You should (briefly) describe what the patch does. There is no need to write the ticket number.

Changed 11 years ago by Jennifer Balakrishnan

Attachment: trac_12699.2.patch added

comment:8 Changed 11 years ago by Jennifer Balakrishnan

New commit message added. 

comment:9 Changed 11 years ago by Jeroen Demeyer

Status: positive_reviewneeds_work

This causes a doctest failure:

sage -t  -force_lib devel/sage/sage/symbolic/expression.pyx
**********************************************************************
File "/padic/scratch/jdemeyer/merger/sage-5.0.beta12/devel/sage-main/sage/symbolic/expression.pyx", line 4381:
    sage: f.coefficient(1)
Exception raised:
    Traceback (most recent call last):
      File "/padic/scratch/jdemeyer/merger/sage-5.0.beta12/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/padic/scratch/jdemeyer/merger/sage-5.0.beta12/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/padic/scratch/jdemeyer/merger/sage-5.0.beta12/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_102[18]>", line 1, in <module>
        f.coefficient(Integer(1))###line 4381:
    sage: f.coefficient(1)
      File "expression.pyx", line 4388, in sage.symbolic.expression.Expression.coefficient (sage/symbolic/expression.cpp:19387)
        if len(s.variables()) > 1:
      File "element.pyx", line 332, in sage.structure.element.Element.__getattr__ (sage/structure/element.c:2919)
      File "parent.pyx", line 330, in sage.structure.parent.getattr_from_other_class (sage/structure/parent.c:3329)
    AttributeError: 'sage.rings.integer.Integer' object has no attribute 'variables'
#0: simplify_sum(expr='sum(q^k,k,0,inf))
#1: simplify_sum(expr=a*'sum(q^k,k,0,inf))
**********************************************************************

comment:10 Changed 10 years ago by Jeroen Demeyer

Priority: blockermajor

comment:11 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11sage-5.12

comment:12 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:13 Changed 9 years ago by Travis Scrimshaw

Authors: Jennifer Balakrishnan
Cc: Volker Braun added
Dependencies: #12691
Milestone: sage-6.2sage-duplicate/invalid/wontfix
Reviewers: R. Andrew Ohana
Status: needs_workneeds_review

No longer needed since #9505 is fixed.

comment:14 Changed 9 years ago by Volker Braun

Resolution: wontfix
Reviewers: Travis Scrimshaw
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.