Opened 6 years ago
Closed 4 years ago
#12699 closed defect (wontfix)
Stopgap for 9505
Reported by: | jen | Owned by: | burcin |
---|---|---|---|
Priority: | major | Milestone: | sage-duplicate/invalid/wontfix |
Component: | symbolics | Keywords: | rd2 |
Cc: | vbraun | Merged in: | |
Authors: | Reviewers: | Travis Scrimshaw | |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
need to use sage.misc.stopgap
instead of sage.misc.misc
Attachments (1)
Change History (15)
comment:1 Changed 6 years ago by
- Priority changed from critical to blocker
comment:2 Changed 6 years ago by
- Description modified (diff)
- Reviewers set to R. Andrew Ohana
- Status changed from new to needs_review
comment:3 Changed 6 years ago by
- Status changed from needs_review to needs_work
comment:4 Changed 6 years ago by
- Status changed from needs_work to needs_review
comment:5 Changed 6 years ago by
comment:7 Changed 6 years ago by
Could you write a proper commit message? "Trac 12692" isn't. You should (briefly) describe what the patch does. There is no need to write the ticket number.
Changed 6 years ago by
comment:8 Changed 6 years ago by
New commit message added.
comment:9 Changed 6 years ago by
- Status changed from positive_review to needs_work
This causes a doctest failure:
sage -t -force_lib devel/sage/sage/symbolic/expression.pyx ********************************************************************** File "/padic/scratch/jdemeyer/merger/sage-5.0.beta12/devel/sage-main/sage/symbolic/expression.pyx", line 4381: sage: f.coefficient(1) Exception raised: Traceback (most recent call last): File "/padic/scratch/jdemeyer/merger/sage-5.0.beta12/local/bin/ncadoctest.py", line 1231, in run_one_test self.run_one_example(test, example, filename, compileflags) File "/padic/scratch/jdemeyer/merger/sage-5.0.beta12/local/bin/sagedoctest.py", line 38, in run_one_example OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags) File "/padic/scratch/jdemeyer/merger/sage-5.0.beta12/local/bin/ncadoctest.py", line 1172, in run_one_example compileflags, 1) in test.globs File "<doctest __main__.example_102[18]>", line 1, in <module> f.coefficient(Integer(1))###line 4381: sage: f.coefficient(1) File "expression.pyx", line 4388, in sage.symbolic.expression.Expression.coefficient (sage/symbolic/expression.cpp:19387) if len(s.variables()) > 1: File "element.pyx", line 332, in sage.structure.element.Element.__getattr__ (sage/structure/element.c:2919) File "parent.pyx", line 330, in sage.structure.parent.getattr_from_other_class (sage/structure/parent.c:3329) AttributeError: 'sage.rings.integer.Integer' object has no attribute 'variables' #0: simplify_sum(expr='sum(q^k,k,0,inf)) #1: simplify_sum(expr=a*'sum(q^k,k,0,inf)) **********************************************************************
comment:10 Changed 5 years ago by
- Priority changed from blocker to major
comment:11 Changed 4 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:12 Changed 4 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:13 Changed 4 years ago by
- Cc vbraun added
- Dependencies #12691 deleted
- Milestone changed from sage-6.2 to sage-duplicate/invalid/wontfix
- Reviewers R. Andrew Ohana deleted
- Status changed from needs_work to needs_review
No longer needed since #9505 is fixed.
comment:14 Changed 4 years ago by
- Resolution set to wontfix
- Reviewers set to Travis Scrimshaw
- Status changed from needs_review to closed
Note: See
TracTickets for help on using
tickets.
Updated patch to import from sage.misc.stopgap.