Opened 8 years ago
Closed 7 years ago
#12694 closed defect (fixed)
Fix four SPKGs with irregular directory structures
Reported by: | kini | Owned by: | kini |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.0 |
Component: | packages: standard | Keywords: | libm4ri elliptic_curves graphs polytopes_db rd2 |
Cc: | ohanar, malb, ekirkman, novoselt, jason, was | Merged in: | sage-5.0.beta10 |
Authors: | Keshav Kini | Reviewers: | R. Andrew Ohana |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #12644 | Stopgaps: |
Description (last modified by )
The following SPKGs do not have a src/
directory:
sage_scripts extcode libm4ri sage_root elliptic_curves graphs sage polytopes_db
The sage spkgs are obviously supposed to be irregular (I guess) but the other four - libm4ri
, elliptic_curves
, graphs
, and polytopes_db
should follow the guidelines given in the developers' guide and have a src/
directory.
Install:
- http://boxen.math.washington.edu/home/keshav/files/fixed-spkgs/elliptic_curves-0.5.spkg
- http://boxen.math.washington.edu/home/keshav/files/fixed-spkgs/libm4ri-20111004.p1.spkg
- http://boxen.math.washington.edu/home/keshav/files/fixed-spkgs/graphs-20070722.p2.spkg
- http://boxen.math.washington.edu/home/keshav/files/fixed-spkgs/polytopes_db-20100210.p1.spkg
Change History (20)
comment:1 Changed 8 years ago by
- Priority changed from major to minor
- Type changed from PLEASE CHANGE to defect
comment:2 Changed 8 years ago by
- Dependencies set to #12644
- Description modified (diff)
comment:3 Changed 8 years ago by
comment:4 Changed 8 years ago by
- Description modified (diff)
The above comment was a test of the newly upgraded trac server. Here are two more SPKGs.
comment:5 Changed 8 years ago by
- Cc ohanar added
- Description modified (diff)
- Status changed from new to needs_review
And the last one.
comment:6 Changed 8 years ago by
these are not the comments you are looking for
comment:8 Changed 8 years ago by
- Reviewers set to R. Andrew Ohana
- Status changed from needs_review to needs_work
the elliptic_curves spkg still has the ellcurves directory (which should now be gone), also at the same time you may as well remove the xreadlines from the spkg-install since the command has be deprecated (in favor of just using an implicit iterator)
comment:9 Changed 8 years ago by
- Status changed from needs_work to needs_review
Oops, how did that happen... fixed (I think).
comment:10 Changed 8 years ago by
- Status changed from needs_review to needs_work
$ hg status ? .SPKG.txt.swp
comment:11 Changed 8 years ago by
You caught me - that's already fixed, download it again :)
comment:12 Changed 8 years ago by
I also would remove Emily as the maintainer of the graphs spkg, she hasn't been around for years (if I had the source for her db file, I would maintain this package, but alas, I don't, maybe Jason or William does?).
comment:14 Changed 8 years ago by
also, in the polytopes_db I would suggest changing the cp to a mv (like you did with the graphs spkg), removes nearly all io assuming you are building and installing on the same disk
comment:15 follow-up: ↓ 16 Changed 8 years ago by
Is the graphs spkg my 8-vertex graph properties database? It's a sqlite database, right? Probably the easiest thing to do is to dump the sql to a text file and put that in src/. We could even just distribute that and build the sqlite database on the fly when the spkg is installed.
comment:16 in reply to: ↑ 15 Changed 8 years ago by
Replying to jason:
We could even just distribute that and build the sqlite database on the fly when the spkg is installed.
I would suggest this, it should reduce the size of the spkg, which is always a good thing, and it shouldn't take long to build. Plus, I did a major refactoring of the SQLDatabase object in Sage last summer, and had to put some special cases in for the Graph's database (that could be fixed with this). In any case, I think this belongs in a separate ticket. For now, mark me as the maintainer of the graphs spkg.
comment:18 Changed 8 years ago by
- Status changed from needs_review to positive_review
ok, looks good now
comment:20 Changed 7 years ago by
- Merged in set to sage-5.0.beta10
- Resolution set to fixed
- Status changed from positive_review to closed
I have uploaded an spkg.