Opened 9 years ago
Closed 9 years ago
#12692 closed defect (fixed)
Stopgap for 12509
Reported by: | roed | Owned by: | was |
---|---|---|---|
Priority: | blocker | Milestone: | sage-5.0 |
Component: | number theory | Keywords: | rd2 |
Cc: | Merged in: | sage-5.0.beta11 | |
Authors: | David Roe, Jennifer Balakrishnan | Reviewers: | R. Andrew Ohana |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | #12691 | Stopgaps: |
Description (last modified by )
Attachments (1)
Change History (11)
comment:1 Changed 9 years ago by
- Dependencies set to #12691
- Status changed from new to needs_review
comment:2 Changed 9 years ago by
- Keywords rd2 added
- Status changed from needs_review to positive_review
comment:3 Changed 9 years ago by
- Priority changed from major to blocker
comment:4 Changed 9 years ago by
- Description modified (diff)
- Reviewers set to R. Andrew Ohana, Jen Balakrishnan
- Status changed from positive_review to needs_work
comment:5 Changed 9 years ago by
- Status changed from needs_work to needs_review
This patch (12692.2.patch) imports from sage.misc.stopgap.
comment:6 Changed 9 years ago by
- Reviewers changed from R. Andrew Ohana, Jen Balakrishnan to R. Andrew Ohana
- Status changed from needs_review to positive_review
Looks good.
comment:7 Changed 9 years ago by
Could you write a proper commit message? "Trac 12692" isn't. You should (briefly) describe what the patch does. There is no need to write the ticket number.
comment:8 Changed 9 years ago by
12692.2.2.patch has a more descriptive commit message.
Changed 9 years ago by
comment:9 Changed 9 years ago by
- Description modified (diff)
Wrapped the commit message over 3 lines (commit messages should not be one long line. If you wrap commit messages, make sure the first line, which appears in hg log
, makes sense by itself).
comment:10 Changed 9 years ago by
- Merged in set to sage-5.0.beta11
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Looks good.