Opened 9 years ago
Last modified 9 years ago
#12691 closed enhancement
Create a stopgap warning — at Version 8
Reported by: | roed | Owned by: | jason |
---|---|---|---|
Priority: | major | Milestone: | sage-5.0 |
Component: | misc | Keywords: | rd2 |
Cc: | Merged in: | ||
Authors: | David Roe, William Stein | Reviewers: | R. Andrew Ohana |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
Sometimes issues can produce mathematically incorrect results, and we should warn users of the problem. If the issue is fixed promptly then nothing more needs to be done, but sometimes tickets remain unresolved for months or years (c.f. #11358). This ticket adds a function that makes it easy to create a second ticket warning users of the problem while it's being resolved.
On trac, this functionality will be supported by the Stopgaps field. Create a new ticket that uses the stopgap
function and include a link to it in the Stopgaps field in the original ticket.
Change History (10)
comment:1 Changed 9 years ago by
- Status changed from new to needs_review
Changed 9 years ago by
comment:2 Changed 9 years ago by
- Keywords rd2 added
- Status changed from needs_review to positive_review
comment:3 Changed 9 years ago by
See #12702 for a followup.
comment:4 Changed 9 years ago by
I think this code is too slow. We want it to be highly optimized so as to not have much of a performance penalty for introducing a stopgap. I'm going to attach a different patch that implements stopgaps, and is an *order of magnitude* faster than this code:
sage: timeit("sage.misc.misc.stopgap('abc', 123)", number=10^5) 100000 loops, best of 3: 2.49 µs per loop sage: import sage.misc.stopgap sage: timeit("sage.misc.stopgap.stopgap('abc', 123)", number=10^5) 100000 loops, best of 3: 388 ns per loop sage: 2.49 / .388 6.41752577319588
comment:5 Changed 9 years ago by
- Status changed from positive_review to needs_work
comment:6 Changed 9 years ago by
- Status changed from needs_work to needs_review
Changed 9 years ago by
comment:7 Changed 9 years ago by
- Reviewers set to R. Andrew Ohana
- Status changed from needs_review to positive_review
everything looks good to me and works how I expect it to, positive review!
comment:8 Changed 9 years ago by
- Description modified (diff)
Looks good.