Opened 9 years ago

Closed 9 years ago

#12685 closed defect (invalid)

[github workflow illustration of #12642!] magma_free interface is broken

Reported by: was Owned by: was
Priority: major Milestone: sage-5.0
Component: interfaces Keywords:
Cc: Merged in:
Authors: Reviewers:
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by kini)

[NOTE: This ticket is solely to illustrate how a potential github/trac workflow would work if #12642 were done using it.]

Branch to merge: kini fix-magma_free ( )

Change History (4)

comment:1 Changed 9 years ago by kini

  • Description modified (diff)

comment:2 Changed 9 years ago by was

I am going to referee this on sage.math:

  1. Extract a copy of Sage-5.0.beta7:
    wstein@sage:/tmp/wstein$ tar xf /home/release/sage-5.0.beta7/
    wstein@sage:/tmp/wstein$ mv sage-5.0.beta7
    wstein@sage:/tmp/wstein/sage-5.0.beta7$ ./sage -br
  1. Clone kini's repo (this takes about 40 seconds), build the code (over an hour CPU time), and try it out:
    wstein@sage:/tmp/wstein/sage-5.0.beta7$ cd devel/
    wstein@sage:/tmp/wstein/sage-5.0.beta7/devel$ git clone sage-git
    wstein@sage:/tmp/wstein/sage-5.0.beta7/devel$ rm sage; ln -s sage-git sage; cd sage-git
    wstein@sage:/tmp/wstein/sage-5.0.beta7/devel/sage-git$ git checkout origin/fix-magma_free
    wstein@sage:/tmp/wstein/sage-5.0.beta7/devel/sage-git$ ../../sage -br
    sage: magma_free('2+3')
  1. Once you are logged into a github account, make some remarks on the code by browsing and make some annotations. First go to then click on the commit id. In this example, my annotation will appear here:
  1. Share our changes. Login to your github account and *FORK* the sagemath/sagelib repo here by clicking on the big "fork" button. Then:
wstein@sage:/tmp/wstein/sage-5.0.beta7/devel/sage-git$ git checkout -b trac_12685
M       sage/interfaces/
Switched to a new branch 'trac_12685'
wstein@sage:/tmp/wstein/sage-5.0.beta7/devel/sage-git$ git commit -av
wstein@sage:/tmp/wstein/sage-5.0.beta7/devel/sage-git$ git push trac_12685

Now my code is at:

And the new (combined) fix is:

comment:3 Changed 9 years ago by was

  • Status changed from new to needs_review

comment:4 Changed 9 years ago by kini

  • Resolution set to invalid
  • Status changed from needs_review to closed

This was a dummy ticket.

Note: See TracTickets for help on using tickets.