Opened 8 years ago

Closed 8 years ago

#12684 closed defect (fixed)

Rename sage/graphs/graph_decompositions/rankwidth/

Reported by: mhansen Owned by: jason, ncohen, rlm
Priority: major Milestone: sage-5.0
Component: graph theory Keywords:
Cc: jdemeyer, ncohen Merged in: sage-5.0.beta11
Authors: Mike Hansen Reviewers: David Coudert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jhpalmieri)

Introduced in #11754, this currently causes problems with #12659 as there is a \_\_init\_\_.py file in this directory and a corresponding extension module rankwidth.pyx.

Apply trac_12684.v2.patch​.

Attachments (2)

trac_12684.patch​ (2.1 KB) - added by mhansen 8 years ago.
trac_12684.v2.patch​ (2.7 KB) - added by jhpalmieri 8 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by mhansen

  • Status changed from new to needs_review

comment:2 Changed 8 years ago by dcoudert

  • Reviewers set to David Coudert
  • Status changed from needs_review to positive_review

I have installed the patch on sage-5.0.beta8 and everything is in order (compilation, docbuild,...).

I give positive review.

David.

Changed 8 years ago by mhansen

comment:3 Changed 8 years ago by jdemeyer

  • Status changed from positive_review to needs_work
  • Work issues set to MANIFEST.in

MANIFEST.in needs to be changed.

comment:4 Changed 8 years ago by jhpalmieri

  • Description modified (diff)
  • Status changed from needs_work to needs_review
  • Work issues MANIFEST.in deleted

Here's a new patch which just adds this change:

  • MANIFEST.in 

    diff --git a/MANIFEST.in b/MANIFEST.in
    a b include .hgignore .hg .hg/* .hgtags 
    66include bundle export install pull sage-push
    77include module_list.py
    88include spkg-delauto spkg-dist spkg-install
    9 include sage/graphs/graph_decompositions/rankwidth/README
    10 include sage/graphs/graph_decompositions/rankwidth/__init__.py
     9include sage/graphs/graph_decompositions/rankwidth_c/README
    1110include sage/libs/gmp/__init__.py
    1211include sage/libs/linbox/matrix_rational_dense_linbox.cpp
    1312include sage/libs/polybori/__init__.py

Changed 8 years ago by jhpalmieri

comment:5 Changed 8 years ago by dcoudert

  • Status changed from needs_review to positive_review

I have installed version 2 of the patch on sage-5.0.beta9 and everything is in order (change in directory name, compilation, docbuild, long tests, functionality, etc.).

comment:6 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.0.beta11
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.