Opened 11 years ago

Closed 11 years ago

#12680 closed defect (fixed)

Fix (a single) hardcoded 'g++' in Singular 3-1-3-3

Reported by: leif Owned by: leif
Priority: major Milestone: sage-5.0
Component: packages: standard Keywords: rd2 spkg CXX C++ compiler hard-coded
Cc: AlexanderDreyer, malb, ohanar Merged in: sage-5.0.beta9
Authors: Leif Leonhardy Reviewers: R. Andrew Ohana
Report Upstream: Completely fixed; Fix reported upstream Work issues:
Branch: Commit:
Dependencies: Stopgaps:

GitHub link to the corresponding issue

Description (last modified by leif)

In src/factory/GNUmakefile.in, we currently have:

# create cf_gmp.h
cf_gmp.h: GNUmakefile gen_cf_gmp.template
        echo "#!/bin/sh" >gen_cf_gmp.sh 
        echo "GMP_H_T=\"`g++ $(LIBCXXFLAGS) -M gen_cf_gmp.cc|grep gmp.h` \"" >>gen_cf_gmp.sh 
        cat gen_cf_gmp.template >>gen_cf_gmp.sh
        $(SHELL) gen_cf_gmp.sh

The attached p6 spkg fixes this (by using $(CXX), as everywhere else), and also two typos.


This bug shows up (and leads to a build error) e.g. if you use a different C++ compiler (or version of g++) by setting CXX and specify CXXFLAGS the "default" g++ doesn't understand.


New spkg: http://boxen.math.washington.edu/home/leif/Sage/spkgs/singular-3-1-3-3.p6.spkg

md5sum: c637e93eff14491d3dff11647b4732af singular-3-1-3-3.p6.spkg

singular-3-1-3-3.p6 (Leif Leonhardy, March 17th 2012)

  • #12680: Fix hardcoded 'g++' (and two typos) in factory/GNUmakefile.in.

Attachments (2)

singular-3-1-3-3.p5-p6.diff (3.9 KB) - added by leif 11 years ago.
Diff between the p5 and my p6. For reference / review only.
factory.GNUmakefile.in.patch (1.0 KB) - added by leif 11 years ago.
This is the new patch to upstream. For reference / review only.

Download all attachments as: .zip

Change History (9)

Changed 11 years ago by leif

Attachment: singular-3-1-3-3.p5-p6.diff added

Diff between the p5 and my p6. For reference / review only.

comment:1 Changed 11 years ago by leif

Authors: Leif Leonhardy
Description: modified (diff)
Status: newneeds_review

Haven't yet looked whether there are other changes pending; I apologize for that.

Changed 11 years ago by leif

This is the new patch to upstream. For reference / review only.

comment:2 Changed 11 years ago by ohanar

Reviewers: R. Andrew Ohana
Status: needs_reviewpositive_review

looks good and works well!

comment:3 in reply to:  2 Changed 11 years ago by leif

Replying to ohanar:

looks good and works well!

Thanks for the review!

Perhaps Alexander (or Martin) wants to report this upstream, as their trac occasionally doesn't like me... ;-) (Haven't yet tried to, though.)

comment:4 Changed 11 years ago by ohanar

Keywords: rd2 added

comment:5 Changed 11 years ago by leif

Report Upstream: Not yet reported upstream; Will do shortly.Completely fixed; Fix reported upstream

Replying to leif:

Perhaps Alexander (or Martin) wants to report this upstream, as their trac occasionally doesn't like me... ;-) (Haven't yet tried to, though.)

Ok, this is now Singular trac ticket #413.


What's "rd2"? Rohana Days II?

comment:6 Changed 11 years ago by ohanar

review days 2 :)

comment:7 Changed 11 years ago by jdemeyer

Merged in: sage-5.0.beta9
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.