Opened 6 years ago
Closed 6 years ago
#12677 closed defect (fixed)
Make the doctests of sage.misc.sageinspect.sage_getargspec independent of ``Poset``
| Reported by: | nthiery | Owned by: | jason |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.0 |
| Component: | misc | Keywords: | |
| Cc: | sage-combinat, mhansen | Merged in: | sage-5.0.beta11 |
| Authors: | Nicolas M. Thiéry | Reviewers: | Anne Schilling |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Description (last modified by )
sage.misc.sageinspect.sage_getargspec uses Poset as example in its doctests. Thus, each time Poset is modified, this file (and its analogue in sagenb) needs to be updated.
This patch replaces the doctest by one that does not depend on other Sage sources. #12536 depends on it.
- Apply in the sagenb repo: trac_12677-sagenb-sageinspect_dont_use_Poset-nt.patch
Attachments (2)
Change History (7)
Changed 6 years ago by
Changed 6 years ago by
comment:1 Changed 6 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:2 follow-up: ↓ 3 Changed 6 years ago by
- Cc mhansen added
comment:3 in reply to: ↑ 2 ; follow-up: ↓ 4 Changed 6 years ago by
- Reviewers set to Anne Schilling
- Status changed from needs_review to positive_review
comment:4 in reply to: ↑ 3 Changed 6 years ago by
Replying to aschilling:
Looks good to me. Unless the PatchBot? gives error messages, we can set a positive review.
Thanks for the review :-)
comment:5 Changed 6 years ago by
- Merged in set to sage-5.0.beta11
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Looks good to me. Unless the PatchBot? gives error messages, we can set a positive review.
Anne