Opened 11 years ago

Closed 11 years ago

#12677 closed defect (fixed)

Make the doctests of sage.misc.sageinspect.sage_getargspec independent of ``Poset``

Reported by: Nicolas M. Thiéry Owned by: Jason Grout
Priority: major Milestone: sage-5.0
Component: misc Keywords:
Cc: Sage Combinat CC user, Mike Hansen Merged in: sage-5.0.beta11
Authors: Nicolas M. Thiéry Reviewers: Anne Schilling
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by Nicolas M. Thiéry)

sage.misc.sageinspect.sage_getargspec uses Poset as example in its doctests. Thus, each time Poset is modified, this file (and its analogue in sagenb) needs to be updated.

This patch replaces the doctest by one that does not depend on other Sage sources. #12536 depends on it.

Attachments (2)

trac_12677-sageinspect_dont_use_Poset-nt.patch (1.5 KB) - added by Nicolas M. Thiéry 11 years ago.
trac_12677-sagenb-sageinspect_dont_use_Poset-nt.patch (1.2 KB) - added by Nicolas M. Thiéry 11 years ago.

Download all attachments as: .zip

Change History (7)

Changed 11 years ago by Nicolas M. Thiéry

Changed 11 years ago by Nicolas M. Thiéry

comment:1 Changed 11 years ago by Nicolas M. Thiéry

Description: modified (diff)
Status: newneeds_review

comment:2 Changed 11 years ago by Mike Hansen

Cc: Mike Hansen added

comment:3 in reply to:  2 ; Changed 11 years ago by Anne Schilling

Reviewers: Anne Schilling
Status: needs_reviewpositive_review

Looks good to me. Unless the PatchBot? gives error messages, we can set a positive review.

Anne

comment:4 in reply to:  3 Changed 11 years ago by Nicolas M. Thiéry

Replying to aschilling:

Looks good to me. Unless the PatchBot? gives error messages, we can set a positive review.

Thanks for the review :-)

comment:5 Changed 11 years ago by Jeroen Demeyer

Merged in: sage-5.0.beta11
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.