Opened 11 years ago
Closed 11 years ago
#12677 closed defect (fixed)
Make the doctests of sage.misc.sageinspect.sage_getargspec independent of ``Poset``
| Reported by: | Nicolas M. Thiéry | Owned by: | Jason Grout |
|---|---|---|---|
| Priority: | major | Milestone: | sage-5.0 |
| Component: | misc | Keywords: | |
| Cc: | Sage Combinat CC user, Mike Hansen | Merged in: | sage-5.0.beta11 |
| Authors: | Nicolas M. Thiéry | Reviewers: | Anne Schilling |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Status badges
Description (last modified by )
sage.misc.sageinspect.sage_getargspec uses Poset as example in its doctests. Thus, each time Poset is modified, this file (and its analogue in sagenb) needs to be updated.
This patch replaces the doctest by one that does not depend on other Sage sources. #12536 depends on it.
- Apply in the sagenb repo: trac_12677-sagenb-sageinspect_dont_use_Poset-nt.patch
Attachments (2)
Change History (7)
Changed 11 years ago by
| Attachment: | trac_12677-sageinspect_dont_use_Poset-nt.patch added |
|---|
Changed 11 years ago by
| Attachment: | trac_12677-sagenb-sageinspect_dont_use_Poset-nt.patch added |
|---|
comment:1 Changed 11 years ago by
| Description: | modified (diff) |
|---|---|
| Status: | new → needs_review |
comment:2 follow-up: 3 Changed 11 years ago by
| Cc: | Mike Hansen added |
|---|
comment:3 follow-up: 4 Changed 11 years ago by
| Reviewers: | → Anne Schilling |
|---|---|
| Status: | needs_review → positive_review |
comment:4 Changed 11 years ago by
Replying to aschilling:
Looks good to me. Unless the PatchBot? gives error messages, we can set a positive review.
Thanks for the review :-)
comment:5 Changed 11 years ago by
| Merged in: | → sage-5.0.beta11 |
|---|---|
| Resolution: | → fixed |
| Status: | positive_review → closed |
Note: See
TracTickets for help on using
tickets.
Looks good to me. Unless the PatchBot? gives error messages, we can set a positive review.
Anne