Opened 8 years ago
Last modified 6 years ago
#12673 needs_info defect
fix sage.media.wav, since it is totally undoctested, and evidently full of confusing bugs
Reported by: | was | Owned by: | jason |
---|---|---|---|
Priority: | minor | Milestone: | sage-6.4 |
Component: | misc | Keywords: | |
Cc: | jason, mhampton | Merged in: | |
Authors: | Reviewers: | ||
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
As I think http://480.sagenb.org/home/pub/137/ amply illustrates, the mere existence of the untested and very buggy module sage.media.wav causes more confusion than it is worth for now. It would be best to remove it from Sage, and only add something back as a result of a new (probably student) project to do things right.
Attachments (1)
Change History (10)
Changed 8 years ago by
comment:1 Changed 8 years ago by
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
- Summary changed from remove sage.media.wav, since it is totally undoctested, and evidently full of confusing bugs to fix sage.media.wav, since it is totally undoctested, and evidently full of confusing bugs
comment:3 Changed 8 years ago by
- Cc jason mhampton added
This is (very tangentially) related to #7668 and this interact by Marshall.
Given that it's not the worst to eventually have easy-to-use wave handling, perhaps it would be appropriate to split the difference between doctesting and deleting. Could one simply comment out all the code and raise (doctested?) NotImplementedError
s for everything here?
comment:4 Changed 8 years ago by
Please fill in your real name as Author.
comment:5 Changed 7 years ago by
- Status changed from needs_review to needs_info
I've changed my mind. I think that we should just replace this by some really nice documentation about how to use the wave
module, given this sage-devel discussion and this ask.sagemath question. What would be appropriate to roughly replace this stuff with?
comment:6 Changed 7 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:7 Changed 6 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:8 Changed 6 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:9 Changed 6 years ago by
- Milestone changed from sage-6.3 to sage-6.4
Alternatively, doctest the code. I've attached a patch to delete it, but maybe that is too draconian.