Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#12663 closed defect (fixed)

Partitions(-1).list() goes into infinte recursion

Reported by: mantepse Owned by: sage-combinat
Priority: minor Milestone: sage-5.1
Component: combinatorics Keywords: Partitions, corner case, days38
Cc: sdenton Merged in: sage-5.1.beta1
Authors: Travis Scrimshaw Reviewers: Tom Denton
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by jdemeyer)

Currently Partitions only checks whether its argument is an integer, but iterating through Partitions(-1) fails. It now creates an empty list.

sage: Partitions(-1).list()
[]

Apply 12663-partitions_iter_fix-ts-rebased.patch

Attachments (2)

trac_12663-partitions_iter_fix-ts.patch (1.3 KB) - added by tscrim 9 years ago.
12663-partitions_iter_fix-ts-rebased.patch (1.1 KB) - added by jdemeyer 9 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 9 years ago by mantepse

  • Description modified (diff)
  • Summary changed from Partitions(-1).list() goes intto infinte recursion to Partitions(-1).list() goes into infinte recursion

comment:2 Changed 9 years ago by tscrim

  • Authors changed from Martin Rubey to Travis Scrimshaw
  • Description modified (diff)
  • Status changed from new to needs_review

comment:3 Changed 9 years ago by tscrim

  • Cc sdenton added
  • Reviewers set to Tom Denton

comment:4 Changed 9 years ago by sdenton

  • Status changed from needs_review to positive_review

comment:5 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.0 to sage-5.1

comment:6 Changed 9 years ago by jdemeyer

  • Status changed from positive_review to needs_work

The commit message of this patch should be changed (using hg qrefresh -e for example):

  1. The "[mq] ..." should not be there.
  2. It's better not to have one long line, line wrapping is recommended. But make sure the first line (displayed by hg log) makes sense just by itself.

Changed 9 years ago by tscrim

comment:7 Changed 9 years ago by tscrim

  • Keywords days38 added
  • Status changed from needs_work to needs_review

Fixed.

comment:8 Changed 9 years ago by sdenton

  • Status changed from needs_review to positive_review

comment:9 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.1.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed

Changed 9 years ago by jdemeyer

comment:10 Changed 9 years ago by jdemeyer

  • Description modified (diff)
Note: See TracTickets for help on using tickets.