Opened 9 years ago

Closed 9 years ago

#12658 closed enhancement (fixed)

Use the matrix displayhook hack for arithmetic subgroup elements

Reported by: davidloeffler Owned by: was
Priority: minor Milestone: sage-5.0
Component: user interface Keywords:
Cc: Merged in: sage-5.0.beta11
Authors: David Loeffler Reviewers: Martin Raum
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #11709 Stopgaps:


This patch makes the print representation of lists of elements of SL2Z more legible. Before:

sage: SL2Z.gens()
([ 0 -1]
[ 1  0], [1 1]
[0 1])


sage: SL2Z.gens()
[ 0 -1]  [1 1]
[ 1  0], [0 1]

Attachments (1)

trac_12658-SL2Z_displayhook.patch (17.3 KB) - added by davidloeffler 9 years ago.
Patch against 5.0.beta7 + #11709

Download all attachments as: .zip

Change History (4)

comment:1 Changed 9 years ago by davidloeffler

  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to enhancement

Changed 9 years ago by davidloeffler

Patch against 5.0.beta7 + #11709

comment:2 Changed 9 years ago by mraum

  • Reviewers set to Martin Raum
  • Status changed from needs_review to positive_review

This is a good idea. The patch looks good. All test pass here, and the patch bot on beta7 is also fine with it.

comment:3 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta11
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.