Opened 8 years ago

Closed 7 years ago

#12656 closed defect (fixed)

Fix inconsistencies in the PolyBoRi interface

Reported by: AlexanderDreyer Owned by: AlexanderDreyer
Priority: major Milestone: sage-5.0
Component: algebra Keywords:
Cc: PolyBoRi, malb, burcin Merged in: sage-5.0.beta9
Authors: Alexander Dreyer Reviewers: Martin Albrecht
Report Upstream: None of the above - read trac for reasoning. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

There are some inconsistencies between PolyBoRi's original interface and Sage's Cython-based reimplementation.

There were uncovered by the newly introduced self-testing feature of the PolyBoRi-shell ipbori. Call ipbori -t with #12655 installed to see the issue.

Current patch

Attachments (2)

polybori-0.8.x.Trac12656.patch (5.9 KB) - added by AlexanderDreyer 8 years ago.
Cython interface consistent with PolyBoRi?'s built-in interface
polybori-0.8.x.Trac12656.2.patch (5.9 KB) - added by jdemeyer 8 years ago.
Fixed weird whitespace, apply only this

Download all attachments as: .zip

Change History (7)

Changed 8 years ago by AlexanderDreyer

Cython interface consistent with PolyBoRi?'s built-in interface

comment:1 Changed 8 years ago by AlexanderDreyer

  • Status changed from new to needs_review

For sage-5.0.beta7 (with #12655) the patch applies and tests well (make ptestlong) on a SuSE Enterprise 11 AMD64.

comment:2 Changed 8 years ago by AlexanderDreyer

  • Description modified (diff)

Also works with plain sage-5.0.beta7 (without #12655).

comment:3 Changed 8 years ago by malb

  • Reviewers set to Martin Albrecht
  • Status changed from needs_review to positive_review

Patch looks good, applies cleanly and passes doctests.

Changed 8 years ago by jdemeyer

Fixed weird whitespace, apply only this

comment:4 Changed 8 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.0.beta9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.