Opened 9 years ago

Closed 9 years ago

#12651 closed defect (fixed)

Don't add each piece of piecewise functions to the legend

Reported by: mjo Owned by: mjo
Priority: major Milestone: sage-5.0
Component: graphics Keywords:
Cc: kcrisman Merged in: sage-5.0.beta9
Authors: Douglas McNeil, Michael Orlitzky Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This was separated from #11225. The fix is given in AskSage 925 by Douglas McNeil? (dsm).

Attachments (1)

sage-trac_12651.patch (1.9 KB) - added by mjo 9 years ago.
Fix the duplicate legend entries and add a doctest

Download all attachments as: .zip

Change History (7)

comment:1 Changed 9 years ago by kcrisman

  • Cc kcrisman added

comment:2 Changed 9 years ago by mjo

  • Authors set to Douglas McNeil, Michael Orlitzky
  • Status changed from new to needs_review

Changed 9 years ago by mjo

Fix the duplicate legend entries and add a doctest

comment:3 Changed 9 years ago by mjo

First patch had two lines with trailing whitespace, I just removed them.

comment:4 follow-up: Changed 9 years ago by kcrisman

  • Reviewers set to Karl-Dieter Crisman
  • Status changed from needs_review to positive_review

It seems like everything is okay here. Certainly it fixes the problem, other keywords do apply to all pieces of the function.

When did the :trac: thing come in? This sounds vaguely familiar... at any rate, it works very nicely in the live doc!

comment:5 in reply to: ↑ 4 Changed 9 years ago by mjo

Replying to kcrisman:

When did the :trac: thing come in? This sounds vaguely familiar... at any rate, it works very nicely in the live doc!

5.0.beta4, apparently. Psyched that I no longer have to worry about word-wrapping "trac #12345" in the doctests.

comment:6 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta9
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.