Opened 11 years ago

Closed 11 years ago

#12651 closed defect (fixed)

Don't add each piece of piecewise functions to the legend

Reported by: Michael Orlitzky Owned by: Michael Orlitzky
Priority: major Milestone: sage-5.0
Component: graphics Keywords:
Cc: Karl-Dieter Crisman Merged in: sage-5.0.beta9
Authors: Douglas McNeil, Michael Orlitzky Reviewers: Karl-Dieter Crisman
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

This was separated from #11225. The fix is given in AskSage 925 by Douglas McNeil? (dsm).

Attachments (1)

sage-trac_12651.patch (1.9 KB) - added by Michael Orlitzky 11 years ago.
Fix the duplicate legend entries and add a doctest

Download all attachments as: .zip

Change History (7)

comment:1 Changed 11 years ago by Karl-Dieter Crisman

Cc: Karl-Dieter Crisman added

comment:2 Changed 11 years ago by Michael Orlitzky

Authors: Douglas McNeil, Michael Orlitzky
Status: newneeds_review

Changed 11 years ago by Michael Orlitzky

Attachment: sage-trac_12651.patch added

Fix the duplicate legend entries and add a doctest

comment:3 Changed 11 years ago by Michael Orlitzky

First patch had two lines with trailing whitespace, I just removed them.

comment:4 Changed 11 years ago by Karl-Dieter Crisman

Reviewers: Karl-Dieter Crisman
Status: needs_reviewpositive_review

It seems like everything is okay here. Certainly it fixes the problem, other keywords do apply to all pieces of the function.

When did the :trac: thing come in? This sounds vaguely familiar... at any rate, it works very nicely in the live doc!

comment:5 in reply to:  4 Changed 11 years ago by Michael Orlitzky

Replying to kcrisman:

When did the :trac: thing come in? This sounds vaguely familiar... at any rate, it works very nicely in the live doc!

5.0.beta4, apparently. Psyched that I no longer have to worry about word-wrapping "trac #12345" in the doctests.

comment:6 Changed 11 years ago by Jeroen Demeyer

Merged in: sage-5.0.beta9
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.