Opened 8 years ago

Closed 8 years ago

#12644 closed defect (fixed)

redundant source in elliptic_curves spkg

Reported by: ohanar Owned by: was
Priority: minor Milestone: sage-5.0
Component: packages: huge Keywords: rd2
Cc: was, cremona Merged in: sage-5.0.beta10
Authors: R. Andrew Ohana Reviewers: Jennifer Balakrishnan
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by ohanar)

I noticed that the rank0, rank1, and rank2 files in the ellcurves "database" were just split versions of the allcurves.00000-09999 file which is now included in the elliptic_curves spkg. Because of this, the spkg is about 2x larger than it should be.


Attachments (1)

elliptic_curves-0.4.patch (3.5 KB) - added by ohanar 8 years ago.
diff for the spkg, for review only

Download all attachments as: .zip

Change History (5)

comment:1 Changed 8 years ago by ohanar

  • Authors set to R. Andrew Ohana
  • Description modified (diff)
  • Priority changed from major to minor
  • Status changed from new to needs_review

Changed 8 years ago by ohanar

diff for the spkg, for review only

comment:2 Changed 8 years ago by jen

  • Keywords rd2 added
  • Status changed from needs_review to positive_review

Looks good. All tests pass.

comment:3 Changed 8 years ago by jdemeyer

  • Reviewers set to Jennifer Balakrishnan

comment:4 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.0.beta10
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.