Opened 5 years ago

Closed 5 years ago

#12642 closed defect (fixed)

magma_free interface is broken

Reported by: was Owned by: was
Priority: major Milestone: sage-5.0
Component: interfaces Keywords:
Cc: Merged in: sage-5.0.beta8
Authors: Nils Bruin Reviewers: William Stein
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Just like #10499, http://magma.maths.usyd.edu.au/calc/ is broken again from sage:

sage: magma_free('2+3')
Traceback (most recent call last):
...
IndexError: list index out of range

Attachments (2)

trac_12642.patch (833 bytes) - added by nbruin 5 years ago.
trac_12642-referee.patch (983 bytes) - added by was 5 years ago.
apply this after the other patch

Download all attachments as: .zip

Change History (6)

Changed 5 years ago by nbruin

comment:1 follow-up: Changed 5 years ago by nbruin

  • Status changed from new to needs_review

That was interesting to see! As coded, it seemed a bit fragile. The replacement code should be less likely to throw errors. It will likely return junk when the site changes again, though.

comment:2 in reply to: ↑ 1 Changed 5 years ago by was

  • Status changed from needs_review to positive_review

Replying to nbruin:

That was interesting to see! As coded, it seemed a bit fragile. The replacement code should be less likely to throw errors. It will likely return junk when the site changes again, though.

Of course. I noticed that there is an "interesting" typo in the code "resluts", i.e., "re - sluts". I've posted a referee patch that fixes that typo.

Changed 5 years ago by was

apply this after the other patch

comment:3 Changed 5 years ago by jdemeyer

  • Authors set to Nils Bruin
  • Reviewers set to William Stein

comment:4 Changed 5 years ago by jdemeyer

  • Merged in set to sage-5.0.beta8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.