Opened 8 years ago

Closed 8 years ago

#12637 closed defect (fixed)

Follow-up to #4949: don't delete the current working directory

Reported by: jhpalmieri Owned by: GeorgSWeber
Priority: blocker Milestone: sage-5.0
Component: build Keywords:
Cc: Merged in: sage-5.0.beta8
Authors: John Palmieri Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jhpalmieri)

On Solaris, running rm -rf DIR fails if DIR is in the path of the current working directory. This happens in sage-spkg, so the temporary build directories $SAGE_BUILD_DIR/$PKG_NAME don't get deleted. Fix this by running cd ... first.

Apply trac_12637-cd-before-rm.patch to the root repo.

Attachments (1)

trac_12637-cd-before-rm.patch (815 bytes) - added by jhpalmieri 8 years ago.
root repo

Download all attachments as: .zip

Change History (6)

comment:1 Changed 8 years ago by jhpalmieri

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 8 years ago by jdemeyer

Could you just add a comment like

# On Solaris, the current working directory cannot be deleted,
# so we "cd" out of $SAGE_BUILD_DIR/$PKG_NAME, see #12637.

comment:3 Changed 8 years ago by jhpalmieri

  • Description modified (diff)

Done. (Also changed the name of the patch file to match the ticket number.)

Changed 8 years ago by jhpalmieri

root repo

comment:4 Changed 8 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:5 Changed 8 years ago by jdemeyer

  • Merged in set to sage-5.0.beta8
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.