Opened 9 years ago

Closed 9 years ago

#12597 closed enhancement (fixed)

Error in creating a Permutation Group

Reported by: dkrenn Owned by: sage-combinat
Priority: major Milestone: sage-5.0
Component: combinatorics Keywords: permutation group
Cc: Merged in: sage-5.0.beta14
Authors: Mike Hansen Reviewers: Daniel Krenn
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

sage: # Define the generators for the group of symmetries of the Tic-Tac-Toe board.
sage: r = Permutation("(1,7,9,3)(2,4,8,6)")
sage: f = Permutation("(1,3)(4,6)(7,9)")
sage: # Generate the group of symmetries for the Tic-Tac-Toe board.
sage: PermutationGroup([r,f])
Traceback (most recent call last):
...
TypeError: 'int' object is not iterable

Should see

Permutation Group with generators [(1,3)(4,6)(7,9), (1,7,9,3)(2,4,8,6)]

This is the result when run on a server running 'Sage Version 4.6, Release Date: 2010-10-30'.

This was reported on the public bug reports from the notebook interface by <warner@…> on 12/1/2011.

Attachments (1)

trac_12597.patch (2.0 KB) - added by mhansen 9 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 9 years ago by mhansen

  • Authors set to Mike Hansen
  • Status changed from new to needs_review
  • Type changed from defect to enhancement

comment:2 Changed 9 years ago by dkrenn

  • Status changed from needs_review to needs_work

This is a positive review, except for one small thing (and I do not whether that is one or not): Maybe there should be a comment on the test in permgroup.py mentioning the trac-number of this ticket. If you think, that it is ok as it is (without this comment), the you can change the status to positive_review.

comment:3 Changed 9 years ago by dkrenn

  • Reviewers set to Daniel Krenn

Changed 9 years ago by mhansen

comment:4 Changed 9 years ago by mhansen

  • Status changed from needs_work to positive_review

I've updated the patch and went ahead and marked it as a positive review.

comment:5 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta14
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.