Opened 9 years ago

Closed 9 years ago

#12576 closed defect (fixed)

OS X Lion: don't require setting SAGE_PORT

Reported by: jhpalmieri Owned by: jdemeyer
Priority: blocker Milestone: sage-5.0
Component: build Keywords: osx lion prereq
Cc: Merged in: sage-5.0.beta13
Authors: John Palmieri Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #4949, #12112 Stopgaps:

Description (last modified by jhpalmieri)

The prereq script requires setting SAGE_PORT to build on OS X Lion. We should remove this requirement, since building successfully on Lion should be imminent.

Apply trac_12576-lion-sage_port.patch to the root repo.

Attachments (1)

trac_12576-lion-sage_port.patch (7.3 KB) - added by jdemeyer 9 years ago.
root repo

Download all attachments as: .zip

Change History (20)

comment:1 Changed 9 years ago by jhpalmieri

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 9 years ago by jdemeyer

  • Status changed from needs_review to needs_work

While you're changing this, you should really also fix the xcodebuild check. At least, redirect 2>/dev/null so we don't see the error messages.

comment:3 Changed 9 years ago by jhpalmieri

With the current patch, xcodebuild is only used on pre-Lion systems. Since whoever worked on prereq before seemed to think that the particular version of Xcode was important in some cases, I think we should keep this check there. I can redirect the output, though.

comment:4 Changed 9 years ago by jhpalmieri

  • Status changed from needs_work to needs_review

comment:5 Changed 9 years ago by jdemeyer

  • Status changed from needs_review to needs_work

Please remove also

echo "Solaris 9: copying work around stdint.h" 
cp $SAGE_ROOT/spkg/base/stdint.h_Solaris9 $SAGE_LOCAL/include/stdint.h 

(the file $SAGE_ROOT/spkg/base/stdint.h_Solaris9 was removed in #11073).

comment:6 Changed 9 years ago by jdemeyer

  • Dependencies set to #4949

comment:7 Changed 9 years ago by jdemeyer

In fact, why not remove all of

if [ "$UNAME" = "SunOS" ] && [ "$RELEASE" = "5.9" ]; then
    echo "WARNING: Building Sage is not supported on Solaris 9"
    echo "but it might work, so the build will continue."
    echo "Solaris 9: copying work around stdint.h"
    cp $SAGE_ROOT/spkg/base/stdint.h_Solaris9 $SAGE_LOCAL/include/stdint.h
fi

if [ "$UNAME" = "SunOS" ] && [ "$RELEASE" = "5.8" ]; then
    echo "WARNING: Building Sage is not supported on Solaris 8"
    echo "but it might work, so the build will continue."
    echo "Solaris 8: copying work around stdint.h"
    cp $SAGE_ROOT/spkg/base/stdint.h_Solaris9 $SAGE_LOCAL/include/stdint.h
fi

as those versions are already checked for above.

comment:8 Changed 9 years ago by jdemeyer

I would also remove

# From Kate Minola kate01123@gmail.com
# On my powerpc-Darwin machine with csh as my shell, when I attempt
# to build SAGE in the background (i.e., "make &") the build
# stops when executing 'prereq-0.2-install'.  The reason is
# that the line
#     which $1 > /dev/null
# issues a SIGTTOU signal (background process attempting to write
# to tty).  Solution:
trap '' TTOU

which refers to a very outdated version of Sage (and I doubt this one line will fix the problem described).

comment:9 Changed 9 years ago by jdemeyer

Replace

XCODE_VERS=`xcodebuild -version | grep Xcode | sed -e 's/[A-Za-z ]//g' 2> /dev/null

by

XCODE_VERS=`xcodebuild -version 2>/dev/null | grep Xcode | sed 's/[A-Za-z ]//g'

comment:10 Changed 9 years ago by jdemeyer

Replace TABs by spaces.

comment:11 Changed 9 years ago by jdemeyer

  • Owner changed from GeorgSWeber to jdemeyer

I would also replace

echo "You are using Xcode version " $XCODE_VERS "."

by

echo "You are using Xcode version $XCODE_VERS."

which is more readable.

comment:12 Changed 9 years ago by jdemeyer

This "if" will never be true (as you already special-cased it above), so this block can be removed:

        if [ $DARWIN_VERSION -gt 10 ]; then
           echo "Probably you need Xcode 4.3 (or later)"
           echo "Also, make sure you install Xcode's"
           echo "Command Line Tools -- see Sage's README.txt."

comment:13 Changed 9 years ago by jhpalmieri

  • Status changed from needs_work to needs_review

Fixed. Here's a new patch.

comment:14 Changed 9 years ago by jdemeyer

  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

comment:15 Changed 9 years ago by jdemeyer

  • Dependencies changed from #4949 to #4949, #11881
  • Milestone changed from sage-5.0 to sage-pending

comment:16 Changed 9 years ago by jdemeyer

Undid the changes to spkg/base/bzip2-1.0.5-install (for compatibility with #12102)

Last edited 9 years ago by jdemeyer (previous) (diff)

comment:17 Changed 9 years ago by jdemeyer

  • Dependencies changed from #4949, #11881 to #4949, #11881, #12112

The parts of this patch which are unrelated to Darwin are moved to #12112.

Changed 9 years ago by jdemeyer

root repo

comment:18 Changed 9 years ago by jdemeyer

  • Dependencies changed from #4949, #11881, #12112 to #4949, #12112
  • Milestone changed from sage-pending to sage-5.0

comment:19 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta13
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.