Opened 6 years ago

Closed 6 years ago

#12484 closed enhancement (fixed)

CombinatorialFreeModule's: customizing the order of terms in the output of elements

Reported by: nthiery Owned by: sage-combinat
Priority: major Milestone: sage-5.0
Component: combinatorics Keywords: Cernay2012
Cc: sage-combinat Merged in: sage-5.0.beta5
Authors: Nicolas M. Thiéry Reviewers: Florent Hivert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12490 Stopgaps:

Description (last modified by nthiery)

As the title says.

By the way, this (partially) refactors sage.misc.misc.repr_lincomb and its use in FreeAlgebra? and friends. It also discards some now useless code in symmetric functions.

Attachments (1)

trac_12484-free_module-monomials_cmp-nt.patch (43.1 KB) - added by nthiery 6 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 6 years ago by nthiery

  • Summary changed from Implements CombinatorialFreeModule(...).print_options(monomials_cmp = ...) to CombinatorialFreeModule's: customizing the order of terms in the output of elements

comment:2 Changed 6 years ago by hivert

  • Keywords Cernay2012 added

comment:3 Changed 6 years ago by nthiery

  • Dependencies set to #12490
  • Reviewers set to Florent Hivert

comment:4 Changed 6 years ago by nthiery

  • Description modified (diff)
  • Status changed from new to needs_review

All test passed (except for the usal timeout on sandpiles) on Sage.5.0.beta3 on Debian x86 64 bits.

comment:5 follow-up: Changed 6 years ago by hivert

For the record: I had a review patch fixing the doc and checking the input of CombinatorialFreeModule? on sage-combinat queue. Nicolas reviewed it positively. I'm uploading here everything folded.

comment:6 in reply to: ↑ 5 Changed 6 years ago by hivert

  • Status changed from needs_review to positive_review

Replying to hivert:

For the record: I had a review patch fixing the doc and checking the input of CombinatorialFreeModule? on sage-combinat queue. Nicolas reviewed it positively. I'm uploading here everything folded.

Actually, Nicolas is uploading it...

comment:7 Changed 6 years ago by jdemeyer

  • Merged in set to sage-5.0.beta5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.