Opened 9 years ago

Closed 9 years ago

#12475 closed defect (fixed)

Define WordMorphism.__ne__

Reported by: tjolivet Owned by: sage-combinat
Priority: major Milestone: sage-5.0
Component: combinatorics Keywords:
Cc: slabbe Merged in: sage-5.0.beta5
Authors: Sébastien Labbé Reviewers: Timo Jolivet
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:


Solve the following problem:

sage: s = WordMorphism('1->121,2->131,3->4,4->1')
sage: s == s.reversal()
sage: s != s.reversal()

which is due to:

sage: s.__ne__?
Object `s.__ne__` not found.

Not much more than this should be added:

def __ne__(self, other):
    return not self.__eq__(other)

Attachments (1)

12475-sl.patch (1.2 KB) - added by slabbe 9 years ago.

Download all attachments as: .zip

Change History (4)

Changed 9 years ago by slabbe

comment:1 Changed 9 years ago by slabbe

  • Authors set to Sébastien Labbé
  • Status changed from new to needs_review

comment:2 Changed 9 years ago by tjolivet

  • Reviewers set to Timo Jolivet
  • Status changed from needs_review to positive_review

The patch applies correctly on my system and fixes the reported problem: positive review.

I couldn't figure out where the PatchBot? fails (yellow icon as of now).

comment:3 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta5
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.