Opened 9 years ago

Closed 9 years ago

#12469 closed defect (fixed)

RuntimeError raised by standard_factorization of a finite word

Reported by: htremblay Owned by: htremblay
Priority: major Milestone: sage-5.1
Component: combinatorics Keywords:
Cc: slabbe Merged in: sage-5.1.beta0
Authors: Hugo Tremblay Reviewers: André Apitzsch
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by aapitzsch)

sage: w=Word('babba')
sage: w.standard_factorization_of_lyndon_factorization()
Traceback (most recent call last)
...
RuntimeError: Bug in standard factorization of words
sage: w=Word('a')
sage: w.standard_factorization()
Traceback (most recent call last)
...
RuntimeError: Bug in standard factorization of words

Apply

  1. trac_12469.patch
  2. trac_12469_correction.patch
  3. trac_12469_reviewer.patch

Attachments (3)

trac_12469.patch (5.0 KB) - added by htremblay 9 years ago.
tested on sage-4.8
trac_12469_reviewer.patch (1.1 KB) - added by aapitzsch 9 years ago.
trac_12469_correction.patch (928 bytes) - added by htremblay 9 years ago.
Applies on the previous patch

Download all attachments as: .zip

Change History (16)

Changed 9 years ago by htremblay

tested on sage-4.8

comment:1 Changed 9 years ago by htremblay

  • Authors set to Hugo Tremblay
  • Cc slabbe added
  • Status changed from new to needs_review

comment:2 Changed 9 years ago by davidloeffler

  • Status changed from needs_review to needs_work

Seems to be failing a doctest on 5.0.beta7 according to the patchbot. This looks completely trivial, but please check.

comment:3 Changed 9 years ago by htremblay

  • Status changed from needs_work to needs_review

Changed 9 years ago by aapitzsch

comment:4 Changed 9 years ago by aapitzsch

  • Description modified (diff)
  • Reviewers set to André Apitzsch

If you are okay with my patch you can change the status to positive review.

comment:5 Changed 9 years ago by htremblay

  • Status changed from needs_review to positive_review

Tested on Sage Version 4.8.

comment:6 Changed 9 years ago by jdemeyer

  • Milestone changed from sage-5.0 to sage-5.1

comment:7 Changed 9 years ago by jdemeyer

  • Status changed from positive_review to needs_work

Can you give the second patch a good commit message?

comment:8 Changed 9 years ago by jdemeyer

*ping*

Changed 9 years ago by htremblay

Applies on the previous patch

comment:9 Changed 9 years ago by htremblay

  • Status changed from needs_work to positive_review

comment:10 Changed 9 years ago by htremblay

  • Status changed from positive_review to needs_work

comment:11 Changed 9 years ago by htremblay

  • Status changed from needs_work to needs_review

comment:12 Changed 9 years ago by jdemeyer

  • Status changed from needs_review to positive_review

comment:13 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.1.beta0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.