Opened 5 years ago

Closed 5 years ago

#12464 closed enhancement (fixed)

Improved uniqueness for combinatorial free modules

Reported by: hivert Owned by: hivert
Priority: major Milestone: sage-5.0
Component: combinatorics Keywords: CombiantorialFreeModule, UniqueRepresentation, Cernay2012
Cc: sage-combinat Merged in: sage-5.0.beta4
Authors: Florent Hivert, Nicolas M. Thiéry Reviewers: Nicolas M. Thiéry, Florent Hivert
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Depending on how they was created, some free modules were different. They are now unique thanks to the classcall mechanism.

I moreover removed a unused code constructing the one of the base ring in __init__.

Attachments (1)

trac_12464-free_module_classcall-fh.patch (4.4 KB) - added by nthiery 5 years ago.

Download all attachments as: .zip

Change History (7)

comment:1 Changed 5 years ago by hivert

  • Status changed from new to needs_review

comment:2 Changed 5 years ago by nthiery

  • Keywords Cernay2012 added
  • Reviewers set to Nicolas M. Thiéry, Florent Hivert
  • Status changed from needs_review to positive_review
  • Summary changed from Better Unicity for combinatorial free modules to Improved uniqueness for combinatorial free modules

Cross reviewed in Cernay. Positive review!

comment:3 Changed 5 years ago by jdemeyer

  • Status changed from positive_review to needs_work

Could this cause

sage -t  -force_lib devel/sage/doc/en/thematic_tutorials/lie/iwahori_hecke_algebra.rst
**********************************************************************
File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/devel/sage-main/doc/en/thematic_tutorials/lie/iwahori_hecke_algebra.rst", line 54:
    sage: H = IwahoriHeckeAlgebraT("B3",q); H
Exception raised:
    Traceback (most recent call last):
      File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/bin/ncadoctest.py", line 1231, in run_one_test
        self.run_one_example(test, example, filename, compileflags)
      File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/bin/sagedoctest.py", line 38, in run_one_example
        OrigDocTestRunner.run_one_example(self, test, example, filename, compileflags)
      File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/bin/ncadoctest.py", line 1172, in run_one_example
        compileflags, 1) in test.globs
      File "<doctest __main__.example_0[3]>", line 1, in <module>
        H = IwahoriHeckeAlgebraT("B3",q); H###line 54:
    sage: H = IwahoriHeckeAlgebraT("B3",q); H
      File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/lib/python/site-packages/sage/misc/classcall_metaclass.py", line 274, in __call__
        return cls.__classcall_private__(cls, *args, **options)
      File "/mnt/usb1/scratch/jdemeyer/merger/sage-5.0.beta4/local/lib/python/site-packages/sage/algebras/iwahori_hecke_algebra.py", line 174, in __classcall_private__
        return super(IwahoriHeckeAlgebraT, cls).__classcall_private__(cls, W, q1=q1, q2=q2, base_ring=base_ring, prefix=prefix)
    TypeError: __classcall_private__() got multiple values for keyword argument 'base_ring'
**********************************************************************

comment:4 Changed 5 years ago by nthiery

  • Status changed from needs_work to positive_review

Oops, sorry; I apparently did not upload the latest version in the queue. There it is!

Changed 5 years ago by nthiery

comment:5 Changed 5 years ago by nthiery

  • Authors changed from Florent Hivert, Nicolas Thiéry to Florent Hivert, Nicolas M. Thiéry

comment:6 Changed 5 years ago by jdemeyer

  • Merged in set to sage-5.0.beta4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.