Opened 9 years ago

Closed 8 years ago

#12463 closed defect (duplicate)

Polyhedron intersection and equality inconsistencies

Reported by: lftabera Owned by: mhampton
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: geometry Keywords: polyhedron, equality, intersection, sd40.5
Cc: vbraun Merged in:
Authors: Reviewers: Andrey Novoseltsev, Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by novoselt)

First of all, polyhedron eq documentation is wrong. It states

    def __eq__(self, other):
        """
        Test whether ``self`` is a strict sub-polyhedron of ``other``.

This does not correspond with the actual code nor the test.

Morevover, intersection of polyhedra produces output with wrong internal representation.

sage: P=Polyhedron([[0,0]], rays=[[1,1]])
sage: Q1=Polyhedron([[0,0],[1,1]])
sage: Q2=Polyhedron([[1,0],[0,1]])
sage: Q=Q1.intersection(Q2)
sage: Q==P
True
sage: Q < P
False

Attachments (1)

trac_12463_polyhedron_eq_typo.patch (1.2 KB) - added by novoselt 9 years ago.

Download all attachments as: .zip

Change History (12)

comment:1 Changed 9 years ago by novoselt

  • Description modified (diff)
  • Summary changed from Polyehdron intersection and equality inconsistencies to Polyhedron intersection and equality inconsistencies

Changed 9 years ago by novoselt

comment:2 Changed 9 years ago by novoselt

  • Authors set to Andrey Novoseltsev
  • Cc vbraun added
  • Keywords sd40.5 added
  • Status changed from new to needs_review

It seems that now inequality/containment are checked correctly, but the documentation of __eq__ still has a typo.

comment:3 Changed 9 years ago by novoselt

Does not seem to be necessary with #11763 where only cmp is left.

comment:4 Changed 8 years ago by vbraun

  • Dependencies set to #11763
  • Status changed from needs_review to positive_review

This is fixed in #11763. Resolve as duplicate.

comment:5 Changed 8 years ago by vbraun

  • Reviewers set to Volker Braun

comment:6 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-5.4 to sage-pending

comment:7 Changed 8 years ago by jdemeyer

  • Milestone changed from sage-pending to sage-5.6

comment:8 Changed 8 years ago by jdemeyer

  • Dependencies changed from #11763 to #11763, #13638
  • Status changed from positive_review to needs_work

This should be rebased to #13638.

comment:9 Changed 8 years ago by vbraun

  • Status changed from needs_work to positive_review

Close ticket as duplicate, see comment:4. Does not need rebasing ;-)

comment:10 Changed 8 years ago by jdemeyer

  • Dependencies #11763, #13638 deleted
  • Milestone changed from sage-5.6 to sage-duplicate/invalid/wontfix

Then you should put the milestone to sage-duplicate/invalid/wontfix. Never expect the release manager to read the ticket comments.

comment:11 Changed 8 years ago by jdemeyer

  • Authors Andrey Novoseltsev deleted
  • Resolution set to duplicate
  • Reviewers changed from Volker Braun to Andrey Novoseltsev, Volker Braun
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.