Opened 7 years ago
Closed 7 years ago
#12456 closed defect (fixed)
Numerical noise on OS X 10.7
Reported by: | jdemeyer | Owned by: | drkirkby |
---|---|---|---|
Priority: | major | Milestone: | sage-5.0 |
Component: | porting | Keywords: | |
Cc: | Merged in: | sage-5.0.beta6 | |
Authors: | Jeroen Demeyer | Reviewers: | Robert Bradshaw, John Palmieri |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
When running Sage on OS X 10.7, there is numerical noise in some doctests.
Attachments (1)
Change History (7)
comment:1 Changed 7 years ago by
Changed 7 years ago by
comment:2 Changed 7 years ago by
- Status changed from new to needs_review
comment:3 follow-up: ↓ 4 Changed 7 years ago by
- Status changed from needs_review to needs_work
I think a lot of these could be fixed without marking them as random (essentially disabling the test). E.g. for
sage: B.is_hermitian(algorithm='naive', tol=1.0e-17)
we could try increasing the tolerance, and for the sign issues, we could write
G.round(6) * sgn(G[0,0])
to force the top-left entry to be positive.
comment:4 in reply to: ↑ 3 Changed 7 years ago by
- Status changed from needs_work to needs_review
Replying to robertwb:
I think a lot of these could be fixed without marking them as random (essentially disabling the test). E.g. for
sage: B.is_hermitian(algorithm='naive', tol=1.0e-17)we could try increasing the tolerance
Doesn't work. On OS X 10.7, the matrix actually is Hermitian to infinite precision.
G.round(6) * sgn(G[0,0])to force the top-left entry to be positive.
Doesn't work either, since you would have to do this on a row-by-row or column-by-column basis for the Gram Schmidt tests. I think this would make things too complicated. Besides, the important thing to check are the defining properties of the Gram-Schmidt reduction, which is checked in these doctests.
comment:5 Changed 7 years ago by
- Reviewers set to Robert Bradshaw, John Palmieri
- Status changed from needs_review to positive_review
Looks good to me, and passes doctests on several platforms (despite what the patchbot thinks).
comment:6 Changed 7 years ago by
- Merged in set to sage-5.0.beta6
- Resolution set to fixed
- Status changed from positive_review to closed
How to deal with this: