Changes between Version 64 and Version 86 of Ticket #12455


Ignore:
Timestamp:
03/12/15 15:01:23 (4 years ago)
Author:
mmezzarobba
Comment:

Replying to rws:

  • Raising a ValueError in FunctionAiryAiGeneral._derivative_ when diff_param == 0 may not be the most appropriate, since (if I'm not mistaken) the partial derivative would make sense mathematically.

A quick look at old and new code shows 1. ValueError, 2. NotImplementedError, 3. assert. So, this needs to be unified to NotImplementedError.

One last thing: IMO hold_derivative should be True by default in airy_ai and airy_bi, except perhaps when the differentiation order is one. But I don't know if that's consistent with the way things are done in other parts of sage symbolics. Thoughts?

I believe the code of this ticket is the only one that has such a parameter, so please feel free to improve it.

Both done (now rather than later to avoid breaking the interface).

I have looked at your patch and it's fine, so if you think the rest is OK please set positive.

I'm okay with everything prior to my commits. Could you (or someone else) have a quick look at my last changes and set the ticket to positive review? Thanks!

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12455

    • Property Reviewers changed from Eviatar Bach, Karl-Dieter Crisman, Burcin Erocal, Ralf Stephan to Eviatar Bach, Karl-Dieter Crisman, Burcin Erocal, Ralf Stephan, Jeroen Demeyer, Marc Mezzarobba
    • Property Owner changed from olazo to rws
    • Property Dependencies changed from #12289 to #12289, #17130
    • Property Milestone changed from sage-6.4 to sage-6.6
    • Property Commit changed from fbd6c357dfdba94d7630d6f2becb411f6169f004 to 2f6945af73219458fb0a2745e2df9e2eea79b055
  • Ticket #12455 – Description

    v64 v86  
    1111{{{
    1212sage: airy_ai(x)
    13 ---------------------------------------------------------------------------
    14 TypeError                                 Traceback (most recent call last)
    15 
    16 /home/oscar/Escritorio/tesis/calculos/<ipython console> in <module>()
    17 
    18 /home/oscar/sage/sage-4.7.1/local/lib/python2.6/site-packages/sage/functions/special.pyc in airy_ai(x)
    19     621    """
    20     622    _init()
    21 --> 623    return RDF(meval("airy_ai(%s)"%RDF(x)))
    22     624
    23     625 def airy_bi(x):
    24 
    25 /home/oscar/sage/sage-4.7.1/local/lib/python2.6/site-packages/sage/structure/parent.so in sage.structure.parent.Parent.__call__ (sage/structure/parent.c:7102)()
    26 
    27 /home/oscar/sage/sage-4.7.1/local/lib/python2.6/site-packages/sage/structure/coerce_maps.so in sage.structure.coerce_maps.NamedConvertMap._call_ (sage/structure/coerce_maps.c:4221)()
    28 
    29 /home/oscar/sage/sage-4.7.1/local/lib/python2.6/site-packages/sage/symbolic/expression.so in sage.symbolic.expression.Expression._real_double_ (sage/symbolic/expression.cpp:5391)()
    30 
    31 /home/oscar/sage/sage-4.7.1/local/lib/python2.6/site-packages/sage/symbolic/expression.so in sage.symbolic.expression.Expression._eval_self (sage/symbolic/expression.cpp:4898)()
    32 
     13...
    3314TypeError: Cannot evaluate symbolic expression to a numeric value.
    3415}}}