Opened 11 years ago

Closed 8 years ago

#12442 closed defect (fixed)

Singular does not state return type of main() functions

Reported by: R. Andrew Ohana Owned by: Georg S. Weber
Priority: major Milestone: sage-6.3
Component: packages: standard Keywords: spkg
Cc: Merged in:
Authors: R. Andrew Ohana, Leif Leonhardy Reviewers: Leif Leonhardy, Jean-Pierre Flori, Volker Braun
Report Upstream: N/A Work issues:
Branch: d45f16b (Commits, GitHub, GitLab) Commit: d45f16bfc4bc4cb22a9c64615dccc97c8412ce78
Dependencies: Stopgaps:

Status badges

Description

This breaks building with clang.

I've posted an spkg fixes this (and #12441) at http://wstein.org/home/ohanar/clang-port/sage-5.0.beta1-src/spkg/standard/singular-3-1-3-3.p5.spkg. (This is a review spkg in case there are more issues with clang down the road.)

Attachments (2)

singular-main-returns.patch (1.7 KB) - added by R. Andrew Ohana 11 years ago.
for review purposes
singular-3.1.6-no_return_type.patch (628 bytes) - added by Leif Leonhardy 8 years ago.
To be put into build/pkgs/singular/patches/.

Download all attachments as: .zip

Change History (27)

Changed 11 years ago by R. Andrew Ohana

Attachment: singular-main-returns.patch added

for review purposes

comment:1 Changed 11 years ago by R. Andrew Ohana

Status: newneeds_review

comment:2 Changed 10 years ago by Leif Leonhardy

Authors: R. Andrew Ohana
Keywords: spkg added
Reviewers: Leif Leonhardy
Status: needs_reviewneeds_work
Summary: singular does not state return types of main methodsSingular does not state return type of main() functions
Work issues: Rebase the spkg on the p6 from #12680.

FWIW, otherwise patch looks good... ;-)

comment:3 Changed 10 years ago by Jeroen Demeyer

Has this been reported upstream (http://www.singular.uni-kl.de:8002/trac/newticket)?

comment:4 Changed 9 years ago by Leif Leonhardy

Work issues: Rebase the spkg on the p6 from #12680.Rebase the spkg on the p6 from #14429.

comment:5 Changed 9 years ago by Leif Leonhardy

Work issues: Rebase the spkg on the p6 from #14429.Rebase the spkg on the one from #14429.

comment:6 Changed 9 years ago by Leif Leonhardy

Looks like there were meanwhile more instances (in Singular 3-1-5), although at least some of them are in test code which does not necessarily get built.

comment:7 Changed 9 years ago by Leif Leonhardy

Work issues: Rebase the spkg on the one from #14429.Rebase the spkg on the latest one (presumably 3-1-5.p8).

Just to make you aware of #14737 (new spkg presumably coming up soon).

comment:8 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11sage-5.12

comment:9 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:10 Changed 9 years ago by Volker Braun

Status: needs_workneeds_info

Might be fixed by #14333, try sage-6.2.beta0 when its out and report back...

comment:11 Changed 9 years ago by Jeroen Demeyer

Component: buildpackages: standard

comment:12 Changed 8 years ago by For batch modifications

Milestone: sage-6.2sage-6.3

comment:13 in reply to:  10 ; Changed 8 years ago by Leif Leonhardy

Status: needs_infoneeds_work

Replying to vbraun:

Might be fixed by #14333, try sage-6.2.beta0 when its out and report back...

Nope, it isn't:

libparse.l:967:1: error: C++ requires a type specifier for all declarations

(as of Sage 6.2 / singular-3.1.6.p1)

Changed 8 years ago by Leif Leonhardy

To be put into build/pkgs/singular/patches/.

comment:14 in reply to:  13 Changed 8 years ago by Leif Leonhardy

Replying to leif:

Replying to vbraun:

Might be fixed by #14333, try sage-6.2.beta0 when its out and report back...

Nope, it isn't:

libparse.l:967:1: error: C++ requires a type specifier for all declarations

(as of Sage 6.2 / singular-3.1.6.p1)

New patch for Singular 3.1.6 attached. (No branch [yet], also because of #13331.)

comment:15 Changed 8 years ago by Leif Leonhardy

Status: needs_workneeds_review

Anyway...

comment:16 Changed 8 years ago by Leif Leonhardy

Authors: R. Andrew OhanaR. Andrew Ohana, Leif Leonhardy
Work issues: Rebase the spkg on the latest one (presumably 3-1-5.p8).

comment:17 Changed 8 years ago by Jean-Pierre Flori

Anyone feels like reviewing this if I create a branch? Then I'll move to #13331.

comment:18 Changed 8 years ago by Volker Braun

This is fixed in Singular-4.0

comment:19 Changed 8 years ago by Jean-Pierre Flori

Great, but is it officially released (I'm aware there is tarball available) and is there anyone working on porting Sage to the new Singular interface?

comment:20 Changed 8 years ago by Volker Braun

Well the webpage still points to 3-1-6. If you want to patch 3-1-6 in the interim then go ahead, all I'm saying is that this will fix itself sooner or later. How much of a priority is building Sage with clang?

comment:21 Changed 8 years ago by Jean-Pierre Flori

Actually I don't care, but I'd like to get #13331 in and this one was mentioned there.

comment:22 Changed 8 years ago by Jean-Pierre Flori

Reviewers: Leif LeonhardyLeif Leonhardy, Jean-Pierre Flori

Still builds fine with the trivial patch, and it makes sense to me.

I assume this was actually tested with clang, so positive review.

comment:23 Changed 8 years ago by Jean-Pierre Flori

Branch: u/jpflori/ticket/12442
Commit: d45f16bfc4bc4cb22a9c64615dccc97c8412ce78
Status: needs_reviewpositive_review

New commits:

d45f16bLet Singular build with clang.

comment:24 Changed 8 years ago by Volker Braun

Reviewers: Leif Leonhardy, Jean-Pierre FloriLeif Leonhardy, Jean-Pierre Flori, Volker Braun

comment:25 Changed 8 years ago by Volker Braun

Branch: u/jpflori/ticket/12442d45f16bfc4bc4cb22a9c64615dccc97c8412ce78
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.