Opened 11 years ago
Closed 8 years ago
#12442 closed defect (fixed)
Singular does not state return type of main() functions
Reported by:  R. Andrew Ohana  Owned by:  Georg S. Weber 

Priority:  major  Milestone:  sage6.3 
Component:  packages: standard  Keywords:  spkg 
Cc:  Merged in:  
Authors:  R. Andrew Ohana, Leif Leonhardy  Reviewers:  Leif Leonhardy, JeanPierre Flori, Volker Braun 
Report Upstream:  N/A  Work issues:  
Branch:  d45f16b (Commits, GitHub, GitLab)  Commit:  d45f16bfc4bc4cb22a9c64615dccc97c8412ce78 
Dependencies:  Stopgaps: 
Description
This breaks building with clang.
I've posted an spkg fixes this (and #12441) at http://wstein.org/home/ohanar/clangport/sage5.0.beta1src/spkg/standard/singular3133.p5.spkg. (This is a review spkg in case there are more issues with clang down the road.)
Attachments (2)
Change History (27)
Changed 11 years ago by
Attachment:  singularmainreturns.patch added 

comment:1 Changed 11 years ago by
Status:  new → needs_review 

comment:2 Changed 10 years ago by
Authors:  → R. Andrew Ohana 

Keywords:  spkg added 
Reviewers:  → Leif Leonhardy 
Status:  needs_review → needs_work 
Summary:  singular does not state return types of main methods → Singular does not state return type of main() functions 
Work issues:  → Rebase the spkg on the p6 from #12680. 
FWIW, otherwise patch looks good... ;)
comment:3 Changed 10 years ago by
Has this been reported upstream (http://www.singular.unikl.de:8002/trac/newticket)?
comment:4 Changed 9 years ago by
Work issues:  Rebase the spkg on the p6 from #12680. → Rebase the spkg on the p6 from #14429. 

comment:5 Changed 9 years ago by
Work issues:  Rebase the spkg on the p6 from #14429. → Rebase the spkg on the one from #14429. 

comment:6 Changed 9 years ago by
Looks like there were meanwhile more instances (in Singular 315), although at least some of them are in test code which does not necessarily get built.
comment:7 Changed 9 years ago by
Work issues:  Rebase the spkg on the one from #14429. → Rebase the spkg on the latest one (presumably 315.p8). 

Just to make you aware of #14737 (new spkg presumably coming up soon).
comment:8 Changed 9 years ago by
Milestone:  sage5.11 → sage5.12 

comment:9 Changed 9 years ago by
Milestone:  sage6.1 → sage6.2 

comment:10 followup: 13 Changed 9 years ago by
Status:  needs_work → needs_info 

Might be fixed by #14333, try sage6.2.beta0 when its out and report back...
comment:11 Changed 9 years ago by
Component:  build → packages: standard 

comment:12 Changed 8 years ago by
Milestone:  sage6.2 → sage6.3 

comment:13 followup: 14 Changed 8 years ago by
Status:  needs_info → needs_work 

Changed 8 years ago by
Attachment:  singular3.1.6no_return_type.patch added 

To be put into build/pkgs/singular/patches/
.
comment:14 Changed 8 years ago by
Replying to leif:
Replying to vbraun:
Might be fixed by #14333, try sage6.2.beta0 when its out and report back...
Nope, it isn't:
libparse.l:967:1: error: C++ requires a type specifier for all declarations(as of Sage 6.2 / singular3.1.6.p1)
New patch for Singular 3.1.6 attached. (No branch [yet], also because of #13331.)
comment:16 Changed 8 years ago by
Authors:  R. Andrew Ohana → R. Andrew Ohana, Leif Leonhardy 

Work issues:  Rebase the spkg on the latest one (presumably 315.p8). 
comment:17 Changed 8 years ago by
Anyone feels like reviewing this if I create a branch? Then I'll move to #13331.
comment:19 Changed 8 years ago by
Great, but is it officially released (I'm aware there is tarball available) and is there anyone working on porting Sage to the new Singular interface?
comment:20 Changed 8 years ago by
Well the webpage still points to 316. If you want to patch 316 in the interim then go ahead, all I'm saying is that this will fix itself sooner or later. How much of a priority is building Sage with clang?
comment:21 Changed 8 years ago by
Actually I don't care, but I'd like to get #13331 in and this one was mentioned there.
comment:22 Changed 8 years ago by
Reviewers:  Leif Leonhardy → Leif Leonhardy, JeanPierre Flori 

Still builds fine with the trivial patch, and it makes sense to me.
I assume this was actually tested with clang, so positive review.
comment:23 Changed 8 years ago by
Branch:  → u/jpflori/ticket/12442 

Commit:  → d45f16bfc4bc4cb22a9c64615dccc97c8412ce78 
Status:  needs_review → positive_review 
New commits:
d45f16b  Let Singular build with clang.

comment:24 Changed 8 years ago by
Reviewers:  Leif Leonhardy, JeanPierre Flori → Leif Leonhardy, JeanPierre Flori, Volker Braun 

comment:25 Changed 8 years ago by
Branch:  u/jpflori/ticket/12442 → d45f16bfc4bc4cb22a9c64615dccc97c8412ce78 

Resolution:  → fixed 
Status:  positive_review → closed 
for review purposes