Opened 10 years ago

Closed 9 years ago

Last modified 9 years ago

#12432 closed defect (worksforme)

zlib fails to compile shared libs with clang

Reported by: ohanar Owned by: GeorgSWeber
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: Merged in:
Authors: Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by ohanar)

The solution is to configure zlib as if you were compiling with gcc.

I've posted an spkg at http://wstein.org/home/ohanar/spkgs/zlib-1.2.6.p0.spkg.

Attachments (2)

zlib-1.2.5.p1.patch (515 bytes) - added by ohanar 10 years ago.
for review purposes
zlib-1.2.6.p0.patch (1.6 KB) - added by ohanar 10 years ago.
diff for the spkg, for review only

Download all attachments as: .zip

Change History (16)

Changed 10 years ago by ohanar

for review purposes

comment:1 Changed 10 years ago by ohanar

  • Status changed from new to needs_review

comment:2 follow-up: Changed 10 years ago by jdemeyer

Could you check whether #12800 by chance fixes this problem?

comment:3 in reply to: ↑ 2 Changed 10 years ago by ohanar

  • Milestone changed from sage-5.0 to sage-duplicate/invalid/wontfix

Replying to jdemeyer:

Could you check whether #12800 by chance fixes this problem?

Yes it does.

comment:4 Changed 10 years ago by ohanar

  • Milestone changed from sage-duplicate/invalid/wontfix to sage-5.0

so it fixes compiling, but there are still issues with the library (which causes other build failures) if the patch is not applied, i'll post a new spkg rebased off of #12800

comment:5 Changed 10 years ago by ohanar

  • Description modified (diff)

Changed 10 years ago by ohanar

diff for the spkg, for review only

comment:6 follow-up: Changed 10 years ago by jdemeyer

I think your patch needs more documentation: mention your patch and explain what goes wrong in the "special update/build" section SPKG.txt.

Also: #12800 still needs a review...

comment:7 Changed 10 years ago by jdemeyer

Also the line

# Apply all patches (currently none)

needs to be changed :-)

comment:8 Changed 10 years ago by jdemeyer

  • Authors set to R. Andrew Ohana
  • Dependencies set to #12800
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to needs_work

comment:9 in reply to: ↑ 6 Changed 10 years ago by leif

Replying to jdemeyer:

Also: #12800 still needs a review...

Fixed, at least for the moment...

comment:10 Changed 10 years ago by jdemeyer

This needs to be rebased to the new version of #12800 (which has positive_review now).

comment:11 Changed 9 years ago by jdemeyer

  • Authors R. Andrew Ohana deleted
  • Component changed from build to packages: standard
  • Dependencies #12800 deleted
  • Milestone changed from sage-5.10 to sage-duplicate/invalid/wontfix
  • Status changed from needs_work to positive_review

Fixed by #14661

comment:12 Changed 9 years ago by jdemeyer

  • Resolution set to duplicate
  • Status changed from positive_review to closed

comment:13 Changed 9 years ago by leif

Rather (meanwhile) "invalid" or "worksforme" than "duplicate".

comment:14 Changed 9 years ago by jdemeyer

  • Resolution changed from duplicate to worksforme
Note: See TracTickets for help on using tickets.