Opened 9 years ago

Closed 4 years ago

#12428 closed defect (invalid)

make flintqs respect global CXX flag

Reported by: ohanar Owned by: GeorgSWeber
Priority: major Milestone: sage-duplicate/invalid/wontfix
Component: packages: standard Keywords:
Cc: Merged in:
Authors: R. Andrew Ohana Reviewers: Julien Puydt, Leif Leonhardy, François Bissey
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The flintqs spkg currently does not respect the global CXX flag, we should fix this (for instance for #12426).

I've posted an spkg at http://wstein.org/home/ohanar/clang-port/sage-5.0.beta1-src/spkg/standard/flintqs-20070817.p7.spkg.

See also #11792.

Attachments (1)

flintqs-20070817.p7.patch (944 bytes) - added by ohanar 9 years ago.
for review purposes

Download all attachments as: .zip

Change History (15)

Changed 9 years ago by ohanar

for review purposes

comment:1 Changed 9 years ago by ohanar

  • Status changed from new to needs_review

comment:2 follow-up: Changed 9 years ago by Snark

Isn't CXX for the C++ compiler and CPP for the C preprocessor?

comment:3 in reply to: ↑ 2 Changed 9 years ago by ohanar

Replying to Snark:

Isn't CXX for the C++ compiler and CPP for the C preprocessor?

Yes, but flintqs disagrees (look at the makefile).

comment:4 follow-up: Changed 9 years ago by leif

  • Authors set to R. Andrew Ohana
  • Reviewers set to Julien Puydt, Leif Leonhardy
  • Status changed from needs_review to needs_work

I don't understand why we still have this separate spkg; as mentioned on previous tickets, a more recent version of FLINT QS is included in FLINT 1.x (and hence also in our FLINT spkg), which we just don't build and/or install there, for whatever reason... :-/


Again, $CXX should be quoted.

comment:5 in reply to: ↑ 4 Changed 7 years ago by jdemeyer

Replying to leif:

as mentioned on previous tickets, a more recent version of FLINT QS is included in FLINT 1.x

Apparently, this rumour is false.

Again, $CXX should be quoted.

Indeed. Or quote the whole argument "CPP=$CXX".

comment:6 Changed 7 years ago by Snark

About the flintqs vs flint rumor, see Bill Hart's mail when I asked about it last year.

comment:7 Changed 7 years ago by jdemeyer

  • Milestone changed from sage-5.11 to sage-5.12

comment:8 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.1 to sage-6.2

comment:9 Changed 7 years ago by jdemeyer

  • Component changed from build to packages: standard

comment:10 Changed 7 years ago by vbraun_spam

  • Milestone changed from sage-6.2 to sage-6.3

comment:11 Changed 6 years ago by vbraun_spam

  • Milestone changed from sage-6.3 to sage-6.4

comment:12 Changed 6 years ago by jdemeyer

  • Description modified (diff)

comment:13 Changed 4 years ago by fbissey

  • Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
  • Reviewers changed from Julien Puydt, Leif Leonhardy to Julien Puydt, Leif Leonhardy, François Bissey
  • Status changed from needs_work to positive_review

Obsoleted by new autotooled flintQS.

comment:14 Changed 4 years ago by vbraun

  • Resolution set to invalid
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.