#12399 closed defect (fixed)
Get pycrypto to build on FreeBSD
Reported by: | kcrisman | Owned by: | pjeremy |
---|---|---|---|
Priority: | major | Milestone: | sage-6.1 |
Component: | porting: BSD | Keywords: | spkg pycrypto |
Cc: | pjeremy, jpflori | Merged in: | |
Authors: | Stephen Montgomery-Smith, Jean-Pierre Flori | Reviewers: | Jean-Pierre Flori |
Report Upstream: | Reported upstream. No feedback yet. | Work issues: | |
Branch: | u/jpflori/ticket/12399 (Commits, GitHub, GitLab) | Commit: | 528d9887a2438668021908cd9ed4cffbc41e9c37 |
Dependencies: | Stopgaps: |
Description (last modified by )
Stephen Montgomery-Smith reports:
OK, I started working on building sage. So far I can get all the spkg's to build except: gap-4.4.12.p6 pycrypto-2.1.0 singular-3-1-3-3.p3 maxima-5.23.2.p3 sage-4.8 The build problem with pycrypto-2.1.0 and singular-3-1-3-3.p3 are easy to fix.
The patch is apparently
--- pycrypto-2.1.0/src/src/libtom/tomcrypt_pk.h-orig 2012-01-21 19:43:56.000000000 +0000 +++ pycrypto-2.1.0/src/src/libtom/tomcrypt_pk.h 2012-01-21 19:45:01.000000000 +0000 @@ -496,7 +496,7 @@ int der_printable_value_decode(int v); /* UTF-8 */ -#if (defined(SIZE_MAX) || __STDC_VERSION__ >= 199901L || defined(WCHAR_MAX) || defined(_WCHAR_T) || defined(_WCHAR_T_DEFINED)) && !defined(LTC_NO_WCHAR) +#if (defined(SIZE_MAX) || __STDC_VERSION__ >= 199901L || defined(WCHAR_MAX) || defined(_WCHAR_T) || defined(_WCHAR_T_DEFINED) || defined(_GCC_WCHAR_T)) && !defined(LTC_NO_WCHAR) #include <wchar.h> #else typedef ulong32 wchar_t;
Use git branch.
Attachments (1)
Change History (14)
comment:1 Changed 10 years ago by
comment:2 follow-up: ↓ 3 Changed 10 years ago by
I erased this comment and the following comment as they were wrong.
comment:3 in reply to: ↑ 2 Changed 10 years ago by
comment:4 Changed 10 years ago by
All that's needed here is a new spkg with an spkg-install that checks whether the patch was applied correctly.
comment:5 Changed 9 years ago by
- Cc jpflori added
comment:6 Changed 9 years ago by
The fix is still needed and let pycrypto build on FreeBSD 9.0 x86. I'll package a spkg this weekend.
comment:7 Changed 9 years ago by
- Description modified (diff)
- Keywords spkg pycrypto added
- Report Upstream changed from N/A to Not yet reported upstream; Will do shortly.
- Reviewers set to Jean-Pierre Flori
- Status changed from new to needs_review
The week-end was kind of long. Uploaded a simple spkg.
Follow up ticket to upgrade pycrypto at #14854. Note the patch should still be needed. The patched file did not change. Time for an upstream bug report I guess.
comment:8 Changed 9 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:9 Changed 9 years ago by
- Report Upstream changed from Not yet reported upstream; Will do shortly. to Reported upstream. No feedback yet.
I've made a git branch and reported upstream at:
comment:10 Changed 9 years ago by
- Branch set to u/jpflori/ticket/12399
- Commit set to 036984d734e7a22f65ab657f24ea68e0149ac850
- Description modified (diff)
comment:11 Changed 9 years ago by
- Commit changed from 036984d734e7a22f65ab657f24ea68e0149ac850 to 528d9887a2438668021908cd9ed4cffbc41e9c37
Branch pushed to git repo; I updated commit sha1. New commits:
528d988 | Let PyCrypto build on FreeBSD.
|
comment:12 Changed 9 years ago by
- Resolution set to fixed
- Status changed from needs_review to closed
comment:13 Changed 7 years ago by
- Description modified (diff)
I can confirm that this ticket is still required for building sage with FreeBSD. It should be harmless to all other OS builds.
Add a new file patches/src.libtom.tomcrypt_pk.h (you will have to add the patches directory as well)
and patch spkg-install as follows: