Opened 10 years ago

Closed 10 years ago

#12383 closed defect (fixed)

Doctest for sage.categories.category.__repr_object_names fails interactively

Reported by: roed Owned by: nthiery
Priority: minor Milestone: sage-5.1
Component: categories Keywords: sd40.5
Cc: Merged in: sage-5.1.beta2
Authors: David Roe Reviewers: Dan Drake
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

The following fails at the command line (rather than in sage -t, where it succeeds) 

sage: Rings().__repr_object_names
BOOM!

Attachments (1)

12383.patch​ (766 bytes) - added by roed 10 years ago.

Download all attachments as: .zip

Change History (6)

Changed 10 years ago by roed

comment:1 Changed 10 years ago by roed

  • Status changed from new to needs_review

comment:2 Changed 10 years ago by nthiery

Hi David!

Thanks for the fix. I am just don't understand how comes those tests did pass before? Which version are you applying this patch onto?

comment:3 Changed 10 years ago by roed

Sorry. This is against sage-5.0.beta1, and the patch fails to apply to sage-4.8. I don't understand why the doctest was succeeding earlier, but sage -t succeeded on my build of sage-5.0.beta1 on sage.math.

comment:4 Changed 10 years ago by ddrake

  • Keywords sd40.5 added
  • Reviewers set to Dan Drake
  • Status changed from needs_review to positive_review

This applies cleanly to 5.1.beta0 and fixes the interactive problem. Positive review.

comment:5 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.1.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.