Opened 8 years ago
Closed 8 years ago
#12382 closed defect (fixed)
Output of a two functions in sage.plot.plot3d.base is nondeterministic due to use of set
Reported by: | roed | Owned by: | jason, was |
---|---|---|---|
Priority: | minor | Milestone: | sage-5.0 |
Component: | graphics | Keywords: | |
Cc: | jpflori | Merged in: | sage-5.0.beta11 |
Authors: | David Roe | Reviewers: | Karl-Dieter Crisman |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description
Graphics3d.tachyon and Graphics3d.mtl_str both join string representations of the textures in Graphics3d.texture_set(). The order of elements pulled out of texture_set() can be different.
Attachments (1)
Change History (9)
Changed 8 years ago by
comment:1 Changed 8 years ago by
- Status changed from new to needs_review
comment:2 Changed 8 years ago by
- Cc jpflori added
comment:3 Changed 8 years ago by
- Reviewers set to Karl-Dieter Crisman
comment:4 Changed 8 years ago by
It was discovered while developing the new doctesting framework at #12415.
comment:5 Changed 8 years ago by
Ok, but I mean on what platform? I'm concerned to try to test that this works properly everywhere. Any other details would be helpful.
comment:6 Changed 8 years ago by
comment:7 Changed 8 years ago by
- Status changed from needs_review to positive_review
Ok... well, I guess since I tested on that platform I can say this is fine. But it seems odd to me that this would make a difference regarding which order the set happens in, if nothing else changed... Anyway, comparing pictures of
G = icosahedron(color='red') + sphere((0,0,0), .6, color='yellow')
in Tachyon before and after the change they seem the same, and everything else seems good.
comment:8 Changed 8 years ago by
- Merged in set to sage-5.0.beta11
- Resolution set to fixed
- Status changed from positive_review to closed
I'm not quite sure why this happens - all is fine with or without on Mac, I know
set
is system-dependent? - but this definitely is a good fix and it's correct in the doctest. Can you tell me where it didn't work? I assume this was discovered due to a doctest failure, but it must have been on an uncommon platform, perhaps?Anyway, modulo that, positive review.