#12381 closed defect (fixed)
Typo in sage.combinat.sf.classical
Reported by: | roed | Owned by: | sage-combinat |
---|---|---|---|
Priority: | major | Milestone: | sage-5.0 |
Component: | combinatorics | Keywords: | |
Cc: | mhansen | Merged in: | sage-5.0.beta12 |
Authors: | David Roe | Reviewers: | Nathann Cohen, Nicolas M. Thiéry, David Loeffler |
Report Upstream: | N/A | Work issues: | |
Branch: | Commit: | ||
Dependencies: | Stopgaps: |
Description (last modified by )
There's a typo in the _element_constructor_, revealed by the new doctesting implementation.
sage: McdJ = MacdonaldPolynomialsJ(QQ) sage: s = SymmetricFunctions(McdJ.base_ring()).s() sage: s._element_constructor(McdJ(s[2,1]) BOOM!
Attachments (1)
Change History (11)
comment:1 Changed 5 years ago by
- Description modified (diff)
- Status changed from new to needs_review
comment:2 Changed 5 years ago by
- Status changed from needs_review to needs_work
comment:3 Changed 5 years ago by
I confirm. Either of you can put a positive review once the ) is added, and it is confirmed (e.g. by the buildbot) that the test pass.
Changed 5 years ago by
comment:4 Changed 5 years ago by
Done. Once patchbot confirms tests pass then everything is good.
comment:5 Changed 5 years ago by
- Status changed from needs_work to needs_review
comment:6 Changed 5 years ago by
Ping! The patchbot does indeed confirm that tests pass, so are we done?
comment:7 Changed 5 years ago by
I think so, but I can't give my own patch a positive review....
comment:8 Changed 5 years ago by
- Reviewers set to Nathann Cohen, Nicolas Thiery, David Loeffler
- Status changed from needs_review to positive_review
comment:9 Changed 5 years ago by
- Merged in set to sage-5.0.beta12
- Resolution set to fixed
- Status changed from positive_review to closed
comment:10 Changed 5 years ago by
- Reviewers changed from Nathann Cohen, Nicolas Thiery, David Loeffler to Nathann Cohen, Nicolas M. Thiéry, David Loeffler
Note: See
TracTickets for help on using
tickets.
Looks good but there is a parenthesis missing in your doctest
:-)
Nathann