Opened 7 years ago
Closed 7 years ago
#12378 closed enhancement (fixed)
Graph chromatic_number documentation
| Reported by: | JoalHeagney | Owned by: | mvngu |
|---|---|---|---|
| Priority: | minor | Milestone: | sage-5.0 |
| Component: | documentation | Keywords: | graph, MILP, chromatic_number |
| Cc: | Merged in: | sage-5.0.beta3 | |
| Authors: | Joal Heagney, Nathann Cohen | Reviewers: | Karl-Dieter Crisman |
| Report Upstream: | N/A | Work issues: | |
| Branch: | Commit: | ||
| Dependencies: | Stopgaps: |
Description
The following page in the documentation http://www.sagemath.org/doc/reference/sage/graphs/graph.html refers to the need to install GLPK, and that chromatic_number uses the less efficient DLX algorithm by default, as opposed to the MILP algorithm.
It's my understanding that sage now includes GLPK by default.
I'd recommend that the current version (4.8) documentation be changed to remove the sentence: "This method requires you to install an optional Sage package like GLPK or COIN-OR’s CBC."
Additionally, we should check for other references to installing "optional" GLPK in the documentation
Attachments (1)
Change History (5)
comment:1 Changed 7 years ago by
- Summary changed from Graph chromatic_number (Document and Default) to Graph chromatic_number documentation
Changed 7 years ago by
comment:2 Changed 7 years ago by
- Status changed from new to needs_review
comment:3 Changed 7 years ago by
- Reviewers set to Karl-Dieter Crisman
- Status changed from needs_review to positive_review
This looks fine and the links work.
comment:4 Changed 7 years ago by
- Merged in set to sage-5.0.beta3
- Resolution set to fixed
- Status changed from positive_review to closed
Note: See
TracTickets for help on using
tickets.
Here is the patch !
:-)I updated the documentation and I do not think there are other instances where GLPK is still mentionned as optional. This being said, I removed the comment about GLPK being faster than the other algorithms. On small examples it just is not true, though the MILP method may be faster when other solvers are installed.
Nathann