Changes between Version 1 and Version 6 of Ticket #12356


Ignore:
Timestamp:
02/01/12 13:43:54 (10 years ago)
Author:
cremona
Comment:

I have started to look at this. The patch applies fine to 4.8 and tests pass, and seem correct to me. I have quite a few suggestions for making the code run faster; the question is whether to insist on any of them now, or put all that into a follow-up ticket, so as not to delay correcting the *wrong* output which unpatched 4.8 gives.

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12356

    • Property Priority changed from major to critical
    • Property Reviewers changed from to John Cremona, William Stein
    • Property Authors changed from John Cremona to John Cremona, William Stein
  • Ticket #12356 – Description

    v1 v6  
    11In sage/schemes/elliptic_curves/cm.py there is a list of imaginary quadratic orders with class number 2, introduced in #11220, but it is incomplete!  Firstly, discriminant -72 is missing since the paper referred to omitted it in error; secondly, all 9 such orders whose maximal order has class number 1 were omitted by mistake.
    22
    3 The patch adds the missing cases and adjusts the doctests (all for Q(sqrt(5)) whose output is now different as more cases are included.
     3The original patch (by JEC) adds the missing cases and adjusts the doctests (all for Q(sqrt(5)) whose output is now different as more cases are included.  The later patches (by WAS) which are independent, do much much more, handling all class numbers up to 100.