Opened 11 years ago

Closed 6 years ago

#12352 closed enhancement (wontfix)

Add some tests for the Qhull optional package

Reported by: mhampton Owned by: tbd
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: packages: optional Keywords: Qhull, polyhedra, polyhedron
Cc: Vincent Delecroix Merged in:
Authors: Frédéric Chapoton Reviewers: Frédéric Chapoton
Report Upstream: N/A Work issues:
Branch: public/ticket/12352 (Commits, GitHub, GitLab) Commit: 547c5084461b0aad197a7f4316a39efe37398601
Dependencies: Stopgaps:

Status badges

Description

At our dear leader's request I am adding a test file for the Qhull optional package.

This will be quite minimal, since what I'd really like is to add a Qhull backend for the Polyhedron class, which would come with its own tests.

If anyone is interested in adding more elaborate tests it wouldn't be very hard since the documentation at the Qhull site is pretty good.

Attachments (1)

trac_12352_Qhull_optional_package_testfile.patch (1.4 KB) - added by mhampton 11 years ago.
adds a minimal test for the Qhull optional package

Download all attachments as: .zip

Change History (13)

Changed 11 years ago by mhampton

adds a minimal test for the Qhull optional package

comment:1 Changed 11 years ago by mhampton

Status: newneeds_review

comment:2 Changed 11 years ago by David Loeffler

Status: needs_reviewneeds_work

The tests need to be marked with "# optional qhull" or something, since otherwise they fail when this optional package isn't installed.

comment:3 Changed 9 years ago by Jeroen Demeyer

Milestone: sage-5.11sage-5.12

comment:4 Changed 9 years ago by For batch modifications

Milestone: sage-6.1sage-6.2

comment:5 Changed 9 years ago by For batch modifications

Milestone: sage-6.2sage-6.3

comment:6 Changed 8 years ago by For batch modifications

Milestone: sage-6.3sage-6.4

comment:7 Changed 8 years ago by Frédéric Chapoton

Branch: public/ticket/12352
Commit: 547c5084461b0aad197a7f4316a39efe37398601
Status: needs_workneeds_review

New commits:

24a3059trac #12352: adding some tests for the Qhull optional package
547c508trac #12352 refreshed

comment:8 Changed 8 years ago by Jeroen Demeyer

Since this is just tests and nothing else, why not add this to a spkg-check file inside the qhull package?

comment:9 in reply to:  8 Changed 7 years ago by Vincent Delecroix

Status: needs_reviewneeds_info

Replying to jdemeyer:

Since this is just tests and nothing else, why not add this to a spkg-check file inside the qhull package?

+1. There is no interface being tested or so.

Doesn't qhull have a testsuite?

Last edited 7 years ago by Vincent Delecroix (previous) (diff)

comment:10 Changed 6 years ago by Matthias Köppe

Cc: Vincent Delecroix added
Milestone: sage-6.4sage-duplicate/invalid/wontfix
Status: needs_infoneeds_review

Marking this as "wontfix". The spkg-check of the qhull package (#21143) seems enough.

comment:11 Changed 6 years ago by Frédéric Chapoton

Authors: Marshall HamptonFrédéric Chapoton
Reviewers: Frédéric Chapoton
Status: needs_reviewpositive_review

comment:12 Changed 6 years ago by Erik Bray

Resolution: wontfix
Status: positive_reviewclosed

Determined to be invalid/duplicate/wontfix (closing as "wontfix" as a catch-all resolution).

Note: See TracTickets for help on using tickets.