Opened 10 years ago
Closed 5 years ago
#12352 closed enhancement (wontfix)
Add some tests for the Qhull optional package
Reported by: | mhampton | Owned by: | tbd |
---|---|---|---|
Priority: | minor | Milestone: | sage-duplicate/invalid/wontfix |
Component: | packages: optional | Keywords: | Qhull, polyhedra, polyhedron |
Cc: | vdelecroix | Merged in: | |
Authors: | Frédéric Chapoton | Reviewers: | Frédéric Chapoton |
Report Upstream: | N/A | Work issues: | |
Branch: | public/ticket/12352 (Commits, GitHub, GitLab) | Commit: | 547c5084461b0aad197a7f4316a39efe37398601 |
Dependencies: | Stopgaps: |
Description
At our dear leader's request I am adding a test file for the Qhull optional package.
This will be quite minimal, since what I'd really like is to add a Qhull backend for the Polyhedron class, which would come with its own tests.
If anyone is interested in adding more elaborate tests it wouldn't be very hard since the documentation at the Qhull site is pretty good.
Attachments (1)
Change History (13)
Changed 10 years ago by
comment:1 Changed 10 years ago by
- Status changed from new to needs_review
comment:2 Changed 10 years ago by
- Status changed from needs_review to needs_work
The tests need to be marked with "# optional qhull" or something, since otherwise they fail when this optional package isn't installed.
comment:3 Changed 8 years ago by
- Milestone changed from sage-5.11 to sage-5.12
comment:4 Changed 8 years ago by
- Milestone changed from sage-6.1 to sage-6.2
comment:5 Changed 8 years ago by
- Milestone changed from sage-6.2 to sage-6.3
comment:6 Changed 7 years ago by
- Milestone changed from sage-6.3 to sage-6.4
comment:7 Changed 7 years ago by
- Branch set to public/ticket/12352
- Commit set to 547c5084461b0aad197a7f4316a39efe37398601
- Status changed from needs_work to needs_review
comment:8 follow-up: ↓ 9 Changed 7 years ago by
Since this is just tests and nothing else, why not add this to a spkg-check
file inside the qhull
package?
comment:9 in reply to: ↑ 8 Changed 6 years ago by
- Status changed from needs_review to needs_info
Replying to jdemeyer:
Since this is just tests and nothing else, why not add this to a
spkg-check
file inside theqhull
package?
+1. There is no interface being tested or so.
Doesn't qhull
have a testsuite?
comment:10 Changed 5 years ago by
- Cc vdelecroix added
- Milestone changed from sage-6.4 to sage-duplicate/invalid/wontfix
- Status changed from needs_info to needs_review
Marking this as "wontfix". The spkg-check of the qhull package (#21143) seems enough.
comment:11 Changed 5 years ago by
- Reviewers set to Frédéric Chapoton
- Status changed from needs_review to positive_review
comment:12 Changed 5 years ago by
- Resolution set to wontfix
- Status changed from positive_review to closed
Determined to be invalid/duplicate/wontfix (closing as "wontfix" as a catch-all resolution).
adds a minimal test for the Qhull optional package