Opened 10 years ago

Closed 10 years ago

#12346 closed enhancement (fixed)

Re-enable Pari hermite form with flag=4 and include_zero_rows=False once it is fixed upstream

Reported by: vbraun Owned by: jason, was
Priority: major Milestone: sage-5.3
Component: linear algebra Keywords:
Cc: Merged in: sage-5.3.beta2
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: Fixed upstream, in a later stable release. Work issues:
Branch: Commit:
Dependencies: #12280, #13320 Stopgaps:

Status badges

Description

As discussed on sage-devel https://groups.google.com/forum/#!topic/sage-devel/CITh4ESK914, Pari has currently a bug where it always returns zero rows in the hnf with flag=4. I disabled this in #12280, but we should re-enable in once it is fixed upstream.

See also: http://pari.math.u-bordeaux.fr/cgi-bin/bugreport.cgi?bug=1271

Attachments (1)

12346_pari_hnf.patch (2.3 KB) - added by jdemeyer 10 years ago.

Download all attachments as: .zip

Change History (8)

comment:1 Changed 10 years ago by jdemeyer

  • Report Upstream changed from Reported upstream. Little or no feedback. to Fixed upstream, but not in a stable release.

comment:2 Changed 10 years ago by jdemeyer

  • Dependencies changed from #12280 to #12280, #13320
  • Milestone changed from sage-feature to sage-5.3
  • Report Upstream changed from Fixed upstream, but not in a stable release. to Fixed upstream, in a later stable release.

Changed 10 years ago by jdemeyer

comment:3 Changed 10 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Status changed from new to needs_review

comment:4 Changed 10 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

Looks good to me!

comment:5 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-5.3 to sage-pending

comment:6 Changed 10 years ago by jdemeyer

  • Milestone changed from sage-pending to sage-5.3

comment:7 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.3.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.