Opened 10 years ago

Closed 10 years ago

#12344 closed enhancement (fixed)

Interface to GINV

Reported by: malb Owned by: tbd
Priority: major Milestone: sage-5.0
Component: packages: optional Keywords: ginv
Cc: wstein Merged in: sage-5.0.beta4
Authors: Martin Albrecht Reviewers: Dmitrii Pasechnik
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description (last modified by dimpase)

We do have an optional GINV SPKG which comes with its own Python interface but no interface to it from Sage.

With the attached patch, this now works. 

sage: P.<x,y,z> = PolynomialRing(GF(127),order='degrevlex')
sage: I = sage.rings.ideal.Katsura(P)
sage: I.groebner_basis(algorithm='ginv')            ...
[z^3 + 22*z^2 - 55*y + 49*z, y^2 - 26*z^2 - 51*y + 51*z, y*z + 52*z^2 + 38*y + 25*z, x + 2*y + 2*z - 1]

Please use the last patch, the 1st one has non-ASCII chars in it.

Attachments (2)

trac12344_ginv.patch​ (4.6 KB) - added by malb 10 years ago.
trac12344_ginv_ascii.patch​ (4.6 KB) - added by dimpase 10 years ago.
cleaned up patch

Download all attachments as: .zip

Change History (10)

comment:1 Changed 10 years ago by malb

  • Description modified (diff)
  • Status changed from new to needs_review

comment:2 Changed 10 years ago by dimpase

there are non-ASCII chars in the diff: "Criterion C1 is Buchberger’s"

Changed 10 years ago by malb

comment:3 follow-up: Changed 10 years ago by malb

fixed

comment:4 in reply to: ↑ 3 Changed 10 years ago by dimpase

Replying to malb:

fixed 

$ iconv -f ascii -t ascii <trac12344_ginv.patch >/dev/null

iconv: (stdin):48:29: cannot convert

There is a weird back quote there... Must be French :-)

Changed 10 years ago by dimpase

cleaned up patch

comment:5 Changed 10 years ago by dimpase

  • Description modified (diff)
  • Status changed from needs_review to positive_review

Tested on Sage 5.0 beta2, Linux x86_64 Debian. It works.

comment:6 Changed 10 years ago by malb

Thanks, the patch looks good. :)

comment:7 Changed 10 years ago by jdemeyer

  • Reviewers set to Dmitrii Pasechnik

comment:8 Changed 10 years ago by jdemeyer

  • Merged in set to sage-5.0.beta4
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.