Opened 10 years ago

Closed 10 years ago

#12337 closed enhancement (invalid)

chomp should have some optional tests.

Reported by: was Owned by: mvngu
Priority: minor Milestone: sage-duplicate/invalid/wontfix
Component: doctest coverage Keywords:
Cc: Merged in:
Authors: Reviewers: Michael Orlitzky
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Status badges

Description

Don't you think it would be really good if there were at least one test of the form "# optional - chomp" in the Sage library? In sage-4.8,

sage: search_src('chomp')

outputs 67 lines of code that somehow mention chomp, but there are no doctests at all.

Change History (3)

comment:1 Changed 10 years ago by jhpalmieri

  • Status changed from new to needs_review

There are about 30 such tests now. Try:

search_src('chomp', 'optional', ignore_case=True)

I propose closing this as invalid.

comment:2 Changed 10 years ago by mjo

  • Milestone changed from sage-5.0 to sage-duplicate/invalid/wontfix
  • Reviewers set to Michael Orlitzky
  • Status changed from needs_review to positive_review

Yup, I found a bunch. From e.g. sage/homology/tests.py,

"""
Tests for chain complexes, simplicial complexes, etc.

These test whether CHomP gives the same answers as Sage's built-in
homology calculator.

TESTS::

    sage: from sage.homology.tests import test_random_chain_complex
    sage: test_random_chain_complex(trials=20)  # optional - CHomP
    sage: test_random_chain_complex(level=2, trials=20)  # optional - CHomP
    sage: test_random_chain_complex(level=3, trials=20)  # long time # optional - CHomP

    sage: from sage.homology.tests import test_random_simplicial_complex
    sage: test_random_simplicial_complex(level=1, trials=20)  # optional - CHomP
    sage: test_random_simplicial_complex(level=2, trials=20)  # optional - CHomP
    sage: test_random_simplicial_complex(level=5/2, trials=10)  # long time # optional - CHomP
"""

comment:3 Changed 10 years ago by was

  • Resolution set to invalid
  • Status changed from positive_review to closed

IMHO, it really sucks that search_src is case sensitive by default. I had no idea. That's why I didn't find the tests.

Note: See TracTickets for help on using tickets.