Opened 7 years ago

Closed 7 years ago

#12334 closed enhancement (fixed)

mark all Lie tests as optional "requires LiE" (this is a *very* easy ticket!)

Reported by: was Owned by: mvngu
Priority: minor Milestone: sage-5.1
Component: doctest coverage Keywords: sd40.5
Cc: mjo Merged in: sage-5.1.beta2
Authors: Michael Orlitzky Reviewers: Benjamin Jones
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description

Looking at the optional tests of the Lie package, shows many that aren't properly marked with "requires LiE" (and many are):

sage: search_src('optional', 'lie')
...
interfaces/lie.py:359:            sage: lie._read_info_files(use_disk_cache=False) #optional -- requires LiE
interfaces/lie.py:360:            sage: lie._trait_names_list #optional
interfaces/lie.py:504:            sage: lie.trait_names() #optional -- requires LiE
interfaces/lie.py:521:            sage: lie._an_element_impl() #optional -- requires LiE
interfaces/lie.py:533:            sage: lie.read(filename)  #optional -- requires LiE
interfaces/lie.py:534:            sage: lie.get('x')        #optional

The point of this ticket is to make them all be marked "#optional -- requires LiE". Pretty easy.

I think this ticket should get a positive review even if

  sage -t -only_optional=LiE lie.py

doesn't pass. Fixing any failures in the lie interface (if there are any) should be a separate ticket.

Attachments (1)

sage-trac_12334.patch (15.9 KB) - added by jdemeyer 7 years ago.
Fix optional syntax in sage/interfaces/lie.py.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 7 years ago by mjo

  • Authors set to Michael Orlitzky
  • Cc mjo added
  • Status changed from new to needs_review

After the patch,

$ sage -t -verbose -long -optional lie.py
...
231 passed and 0 failed.
$ sage -t -verbose -long -only-optional lie.py
...
168 passed and 0 failed.
$ sage -t -verbose -long -only-optional=lie lie.py
...
168 passed and 0 failed.

comment:2 Changed 7 years ago by benjaminfjones

  • Keywords sd40.5 added
  • Reviewers set to Benjamin Jones

comment:3 Changed 7 years ago by benjaminfjones

  • Status changed from needs_review to positive_review

Patch looks good and I get the same tests passed numbers as Michael at comment 1. Positive review.

Changed 7 years ago by jdemeyer

Fix optional syntax in sage/interfaces/lie.py.

comment:4 Changed 7 years ago by jdemeyer

  • Merged in set to sage-5.1.beta2
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.