Opened 11 years ago

Closed 11 years ago

#12330 closed enhancement (fixed)

Increase eval_using_file_cutoff for gp interface

Reported by: Jeroen Demeyer Owned by: William Stein
Priority: minor Milestone: sage-5.0
Component: interfaces Keywords:
Cc: Merged in: sage-5.0.beta1
Authors: Jeroen Demeyer Reviewers: Georg S. Weber
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #12221 Stopgaps:

Status badges

Description

The gp pexpect interface uses "eval_using_file_cutoff=50", which is extremely short. This almost certainly causes inefficiencies because files will need to be used a lot. Most likely, this was set to 50 to mask bug #12221. Now that #12221 is fixed, this can be put back to a more reasonable value like 1024.

Attachments (1)

12330_gp.patch (734 bytes) - added by Jeroen Demeyer 11 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 11 years ago by Jeroen Demeyer

Dependencies: #12221

Changed 11 years ago by Jeroen Demeyer

Attachment: 12330_gp.patch added

comment:2 Changed 11 years ago by Jeroen Demeyer

Status: newneeds_review

comment:3 Changed 11 years ago by Georg S. Weber

Reviewers: Georg S. Weber
Status: needs_reviewpositive_review

Looks good to me.

;-)

comment:4 Changed 11 years ago by Jeroen Demeyer

Merged in: sage-5.0.beta1
Resolution: fixed
Status: positive_reviewclosed
Note: See TracTickets for help on using tickets.