Opened 8 years ago

Closed 8 years ago

#12312 closed defect (fixed)

Disable parallel building of ATLAS

Reported by: jdemeyer Owned by: tbd
Priority: blocker Milestone: sage-4.8
Component: packages: standard Keywords:
Cc: drkirkby, vbraun Merged in: sage-4.8.rc0
Authors: Jeroen Demeyer Reviewers: Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

From the spkg-install of ATLAS:

# we need to disable parallel builds
os.environ['MAKE'] += ' -j1'

but later in the same file:

rc = os.system('make shared cshared')

The latter command doesn't see the "-j1", therefore might be built in parallel since #12016. The solution is to replace "make" by "$MAKE".

I'm making this a sage-4.8 blocker, since this causes the Solaris linker to hang.

spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/atlas-3.8.4.p1.spkg

Attachments (1)

atlas-3.8.4.p1.diff (13.6 KB) - added by jdemeyer 8 years ago.
Diff for the atlas spkg, for review only

Download all attachments as: .zip

Change History (8)

comment:1 Changed 8 years ago by jdemeyer

  • Summary changed from Fix parallel building of ATLAS to Disable parallel building of ATLAS

comment:2 Changed 8 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)
  • Status changed from new to needs_review
  • Type changed from PLEASE CHANGE to defect

Changed 8 years ago by jdemeyer

Diff for the atlas spkg, for review only

comment:3 Changed 8 years ago by jdemeyer

  • Description modified (diff)

comment:4 Changed 8 years ago by vbraun

  • Reviewers set to Volker Braun
  • Status changed from needs_review to positive_review

I don't understand why calling make builds in parallel here; Does MAKEFLAGS contain a -j option (we don't set it by default)? Calling $MAKE is the right thing to do to pass through other options but again I don't understand how it fixes the Solaris issue.

comment:5 Changed 8 years ago by jdemeyer

Volker, see #12016.

comment:6 Changed 8 years ago by jdemeyer

  • Description modified (diff)

comment:7 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.8.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.