Opened 9 years ago

Closed 9 years ago

#12311 closed defect (fixed)

In spkgs, run testcc.sh and testcxx.sh without explicit path

Reported by: jdemeyer Owned by: tbd
Priority: minor Milestone: sage-5.0
Component: packages: standard Keywords:
Cc: Merged in: sage-5.0.beta11
Authors: John Palmieri Reviewers: Jeroen Demeyer
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: #11073, #11920, #12304, #12694 Stopgaps:

Status badges

Description (last modified by jdemeyer)

#11073 changes the location of testcc.sh and testcxx.sh to spkg/bin. The following spkgs refer explicitly to $SAGE_LOCAL/bin/testcc.sh:

  • singular (fixed by #12562)
  • cliquer (also change the path to sage-env in a comment in Makefile.patch)
  • rubiks
  • sympow (fixed by #11920)

The following spkgs have testcc.sh included in the spkg:

  • libm4ri
  • libm4rie (fixed by #12501)

testcxx.sh is never used.

Changing these spkgs should allow us to stop copying testcc.sh and testcxx.sh from spkg/bin to local/bin in #12631.

New spkgs:

Attachments (4)

trac_12311-root.patch​ (674 bytes) - added by jhpalmieri 9 years ago.
root repo
trac_12311-cliquer.patch​ (1.7 KB) - added by jhpalmieri 9 years ago.
patch for cliquer spkg; for review only
trac_12311-libm4ri.patch​ (5.9 KB) - added by jhpalmieri 9 years ago.
patch for libm4ri spkg; for review only
trac_12311-rubiks.patch​ (1.3 KB) - added by jhpalmieri 9 years ago.
patch for rubiks spkg; for review only

Download all attachments as: .zip

Change History (19)

comment:1 Changed 9 years ago by jdemeyer

  • Description modified (diff)

comment:2 Changed 9 years ago by jdemeyer

  • Dependencies set to #11073, #11920
  • Description modified (diff)

comment:3 Changed 9 years ago by jdemeyer

  • Dependencies changed from #11073, #11920 to #11073, #11920, #12304
  • Description modified (diff)

comment:4 Changed 9 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 9 years ago by jdemeyer

  • Description modified (diff)

comment:6 Changed 9 years ago by jdemeyer

  • Priority changed from major to minor

comment:7 Changed 9 years ago by jdemeyer

  • Description modified (diff)

comment:8 Changed 9 years ago by jhpalmieri

  • Authors set to John Palmieri
  • Description modified (diff)
  • Status changed from new to needs_review

Here are spkgs which make the remaining changes. (Since the necessary changes are mostly trivial, I thought we could deal with them all on this ticket.) Is it worth changing dir-0.1-install, since that file is likely to disappear anyway? I'll provide a patch for that, too, in case we want to use it for testing.

Changed 9 years ago by jhpalmieri

root repo

Changed 9 years ago by jhpalmieri

patch for cliquer spkg; for review only

comment:9 Changed 9 years ago by jhpalmieri

  • Description modified (diff)

Changed 9 years ago by jhpalmieri

patch for libm4ri spkg; for review only

comment:10 Changed 9 years ago by jhpalmieri

  • Dependencies changed from #11073, #11920, #12304 to #11073, #11920, #12304, #12694

comment:11 Changed 9 years ago by jdemeyer

  • Status changed from needs_review to needs_work

in SPKG.txt, 

=== rubiks-20070912.p17 (John Palmieri, 23 March 2012) ===

should be 

=== rubiks-20070912.p18 (John Palmieri, 23 March 2012) ===

Changed 9 years ago by jhpalmieri

patch for rubiks spkg; for review only

comment:12 Changed 9 years ago by jhpalmieri

  • Status changed from needs_work to needs_review

Oops, sorry, fixed.

comment:13 follow-up: Changed 9 years ago by jdemeyer

  • Description modified (diff)
  • Reviewers set to Jeroen Demeyer
  • Status changed from needs_review to positive_review

Looks good to me, thanks!

I propose not to apply the SAGE_ROOT patch and leave that to #12631.

comment:14 in reply to: ↑ 13 Changed 9 years ago by jhpalmieri

Replying to jdemeyer:

Looks good to me, thanks!

I propose not to apply the SAGE_ROOT patch and leave that to #12631.

That's fine with me.

comment:15 Changed 9 years ago by jdemeyer

  • Merged in set to sage-5.0.beta11
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.