Changes between Version 98 and Version 100 of Ticket #12299


Ignore:
Timestamp:
06/17/12 02:27:01 (9 years ago)
Author:
kcrisman
Comment:

Okay, I've created a reviewer patch. Now I know the formatting is right because I added this to the reference manual and looked.

I also made some linebreaks earlier, made one set of tests optional because they require the internet (I've checked this), and made the file temporary that wasn't before.

So in theory, this should be wonderful. Only now I've horribly broken something, because these files in the os.path.exists tests no longer exist and those tests fail! I have precisely zero explanation; every time I made them live in the current directory, like just DNA.png, it worked, every time I put them someplace else it didn't.

What's particularly odd about this is that the other test which imports SAGE_TMP used to pass, and then started failing. For no discernible reason. So I'm wondering if I just destroyed something else on my computer (how, I don't know - I've just been working on this patch).

So 'needs review' still. I really am stumped, as this should be completely done now, but isn't.

On the plus side, it looks like people like the functionality!

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12299 – Description

    v98 v100  
    3030sage: hg_sage.apply("http://trac.sagemath.org/sage_trac/raw-attachment/ticket/12299/trac_12299_jmoldata_doctests.patch")
    3131sage: hg_sage.apply("http://trac.sagemath.org/sage_trac/raw-attachment/ticket/12299/trac_12299_jmoldata_doctests2.patch")
     32sage: hg_sage.apply("http//trac.sagemath.org/sage_trac/raw-attachment/ticket/12299/trac_12299-reviewer.patch")
    3233sage: exit
    3334./sage -f  "http://www.uwosh.edu/faculty_staff/gutow/jmol-12.3.27.p0.spkg"
     
    5354
    5455Complete doctest coverage in jmoldata.py: attachment:trac_12299_jmoldata_doctests.patch
    55 attachment:trac_12299_jmoldata_doctests2.patch
     56attachment:trac_12299_jmoldata_doctests2.patch attachment:trac_12299-reviewer.patch
    5657
    5758These patches include all the changes in #9238 plus.