Opened 6 years ago

Closed 5 years ago

#12251 closed enhancement (fixed)

Implementation of Littelmann path model for crystals

Reported by: aschilling Owned by: sage-combinat
Priority: major Milestone: sage-5.3
Component: combinatorics Keywords: crystals, sd40
Cc: sage-combinat Merged in: sage-5.3.beta1
Authors: Mark Shimozono, Anne Schilling Reviewers: Anne Schilling, Mark Shimozono
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by aschilling)

This patch implements the crystal graph using the Littelmann path model. The elements are LS paths generated from the straight-line path to a given weight. Also, the iterator function and lists in crystals is cleaned up.

Attachments (1)

trac_12251-littelmann-as.patch (30.9 KB) - added by aschilling 5 years ago.

Download all attachments as: .zip

Change History (10)

comment:1 Changed 5 years ago by aschilling

  • Description modified (diff)
  • Reviewers set to Anne Schilling, Mark Shimozono
  • Status changed from new to needs_review

comment:2 Changed 5 years ago by aschilling

Hi Mark,

The latest version of the patch is attached and ready for the final review (it is also on the sage-combinat queue).

Anne

comment:3 Changed 5 years ago by aschilling

  • Description modified (diff)
  • Keywords sd40 added
  • Milestone changed from sage-5.1 to sage-5.2

comment:4 Changed 5 years ago by mshimo

  • Status changed from needs_review to positive_review

comment:5 Changed 5 years ago by jdemeyer

  • Milestone changed from sage-5.2 to sage-5.3

comment:6 follow-up: Changed 5 years ago by jdemeyer

  • Status changed from positive_review to needs_work

There is a doctest failure:

sage -t --long "devel/sage/sage/categories/classical_crystals.py"
**********************************************************************
File "/usr/local/src/sage-5.2.rc1/devel/sage/sage/categories/classical_crystals.py", line 323:
    sage: TestSuite(fb4(1,0,1,0)).run(verbose = True)  # long time (8s on sage.math, 2011)
Expected:
    running ._test_an_element() . . . pass
    running ._test_category() . . . pass
    running ._test_elements() . . .
    Running the test suite of self.an_element()
      running ._test_category() . . . pass
      running ._test_eq() . . . pass
      running ._test_not_implemented_methods() . . . pass
      running ._test_pickling() . . . pass
      running ._test_stembridge_local_axioms() . . . pass
      pass
    running ._test_elements_eq() . . . pass
    running ._test_enumerated_set_contains() . . . pass
    running ._test_enumerated_set_iter_cardinality() . . . pass
    running ._test_enumerated_set_iter_list() . . .Enumerated set too big; skipping test; see ``self.max_test_enumerated_set_loop``
    pass
    running ._test_eq() . . . pass
    running ._test_fast_iter() . . . pass
    running ._test_not_implemented_methods() . . . pass
    running ._test_pickling() . . . pass
    running ._test_some_elements() . . . pass
    running ._test_stembridge_local_axioms() . . . pass
Got:
    running ._test_an_element() . . . pass
    running ._test_category() . . . pass
    running ._test_elements() . . .
      Running the test suite of self.an_element()
      running ._test_category() . . . pass
      running ._test_eq() . . . pass
      running ._test_not_implemented_methods() . . . pass
      running ._test_pickling() . . . pass
      running ._test_stembridge_local_axioms() . . . pass
      pass
    running ._test_elements_eq() . . . pass
    running ._test_enumerated_set_contains() . . . pass
    running ._test_enumerated_set_iter_cardinality() . . . pass
    running ._test_enumerated_set_iter_list() . . . pass
    running ._test_eq() . . . pass
    running ._test_fast_iter() . . . pass
    running ._test_not_implemented_methods() . . . pass
    running ._test_pickling() . . . pass
    running ._test_some_elements() . . . pass
    running ._test_stembridge_local_axioms() . . . pass
**********************************************************************

Changed 5 years ago by aschilling

comment:7 in reply to: ↑ 6 Changed 5 years ago by aschilling

Thank you Jeroen for catching this! It should be fixed in the new attached patch.

Anne

comment:8 Changed 5 years ago by aschilling

  • Status changed from needs_work to positive_review

comment:9 Changed 5 years ago by jdemeyer

  • Merged in set to sage-5.3.beta1
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.