Opened 8 years ago

Closed 8 years ago

#12248 closed defect (fixed)

Do not run "make -q" when upgrading

Reported by: jdemeyer Owned by: GeorgSWeber
Priority: blocker Milestone: sage-4.8
Component: build Keywords: sd35.5
Cc: Merged in: sage-4.8.rc0
Authors: Jeroen Demeyer Reviewers: John Palmieri, Volker Braun
Report Upstream: N/A Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The script spkg/install contains the lines

# Skip the rest if nothing to do (i.e., to [re]build):
# If "make" doesn't understand the -q option (although we require
# GNU make, which supports it), it should exit with a non-zero status
# which is not a problem.
if ${MAKE:-make} -q -f standard/deps $1; then
    echo "Nothing to (re)build / all up-to-date."
    exit 0
fi

This runs make with the -q option, which (via the makefile spkg/standard/deps) in turn runs sage-spkg. This changed recently, before #12016 make -q didn't run sage-spkg.

When upgrading, the file sage-spkg is not automatically upgraded, so we can have an old sage-spkg which does not understand the -q option which causes build errors (only visible in the log files), for example in spkg/logs/patch-2.5.9.p2.log.

This is a problem introduced by #12016.

Attachments (1)

12248_make_q.patch (1.5 KB) - added by jdemeyer 8 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 8 years ago by jdemeyer

  • Type changed from PLEASE CHANGE to defect

comment:2 Changed 8 years ago by jdemeyer

  • Authors set to Jeroen Demeyer
  • Description modified (diff)

Changed 8 years ago by jdemeyer

comment:3 Changed 8 years ago by jdemeyer

  • Status changed from new to needs_review

comment:4 Changed 8 years ago by jdemeyer

  • Description modified (diff)

comment:5 Changed 8 years ago by jdemeyer

Successfully tested building from scratch and upgrading from sage-4.5.1.

comment:6 Changed 8 years ago by jhpalmieri

Why did #12016 cause this? Is it because of all of the plus signs in spkg/standard/deps?

comment:7 follow-ups: Changed 8 years ago by jhpalmieri

Unless I made a mistake, I was able to upgrade from 4.4 and 4.5.3 to Sage 4.8.alpha6 plus #9958 and its prerequisites (since that's what I was looking at earlier). I was also able to upgrade after applying the patch here. The patch looks okay to me, but I'm not sure it should be a blocker.

comment:8 in reply to: ↑ 7 Changed 8 years ago by jdemeyer

  • Description modified (diff)

Replying to jhpalmieri:

Why did #12016 cause this? Is it because of all of the plus signs in spkg/standard/deps?

Yes. Those plus signs mark a make rule as recursive.

Replying to jhpalmieri:

Unless I made a mistake, I was able to upgrade from 4.4 and 4.5.3 to Sage 4.8.alpha6 plus #9958 and its prerequisites (since that's what I was looking at earlier). I was also able to upgrade after applying the patch here.

Perhaps I should have been more clear. The upgrade might work without this patch, but you will see a failed build attempt for example in spkg/logs/patch-2.5.9.p2.log.

comment:9 in reply to: ↑ 7 Changed 8 years ago by jdemeyer

  • Reviewers set to John Palmieri

Replying to jhpalmieri:

The patch looks okay to me

Meaning "positive review"?

I'm not sure it should be a blocker.

I disagree since it causes non-fatal build errors. Seeing a scary message "An error occured... please contact sage-devel..." isn't good. Besides, this might possibly lead to an actual build failure.

comment:10 Changed 8 years ago by vbraun

  • Reviewers changed from John Palmieri to John Palmieri, Volker Braun
  • Status changed from needs_review to positive_review

Looks good to me!

comment:11 Changed 8 years ago by vbraun

  • Keywords sd35.5 added

comment:12 Changed 8 years ago by jdemeyer

  • Merged in set to sage-4.8.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.