Opened 9 years ago

Closed 9 years ago

#12245 closed defect (fixed)

M4RIE test suite fails due to missing dependencies

Reported by: davidloeffler Owned by: tbd
Priority: minor Milestone: sage-4.8
Component: packages: standard Keywords: m4rie
Cc: malb Merged in: sage-4.8.rc0
Authors: Martin Albrecht, David Loeffler Reviewers: Martin Albrecht, David Loeffler
Report Upstream: None of the above - read trac for reasoning. Work issues:
Branch: Commit:
Dependencies: Stopgaps:

Description (last modified by jdemeyer)

The M4RIE (cf. #9562) test script has dependencies on some libraries which are not made explicit in spkg/standard/deps or SPKG.txt. These include (at least) Givaro, NTL and GMP/MPIR. Since the Sage build script doesn't know about these dependencies, this means that building Sage in parallel with SAGE_CHECK=yes can fail.

Apply trac12245_m4rie_fix_deps.2.patch to Sage root repository.

Install http://sage.math.washington.edu/home/malb/spkgs/libm4rie-20111004.p1.spkg

Attachments (2)

trac12245_m4rie_fix_deps.patch (814 bytes) - added by malb 9 years ago.
trac12245_m4rie_fix_deps.2.patch (825 bytes) - added by davidloeffler 9 years ago.
sage root repo -- apply only this patch

Download all attachments as: .zip

Change History (14)

comment:1 Changed 9 years ago by malb

  • Description modified (diff)

Changed 9 years ago by malb

comment:2 Changed 9 years ago by malb

  • Authors set to Martin Albrecht
  • Description modified (diff)
  • Report Upstream changed from N/A to None of the above - read trac for reasoning.
  • Status changed from new to needs_review

the attached patch should fix the issue but I haven't tested it.

comment:3 Changed 9 years ago by davidloeffler

Should we not change SPKG.txt to match?

comment:4 Changed 9 years ago by davidloeffler

  • Status changed from needs_review to needs_work

Patch does not apply (conflicts with #12016)

Changed 9 years ago by davidloeffler

sage root repo -- apply only this patch

comment:5 Changed 9 years ago by davidloeffler

Here's an essentially equivalent patch which will apply to versions from 4.8.alpha5 onwards. But we should still fix the spkg.txt file.

comment:6 Changed 9 years ago by malb

Ah, thanks. I was in the process of building alpha5. I'll provide an updated SPKG with an updated SPKG.txt.

comment:8 Changed 9 years ago by davidloeffler

  • Status changed from needs_work to needs_review

I'm happy with the changes to SPKG.txt, so if you are happy with the deps patch, everybody's happy :-)

comment:9 Changed 9 years ago by davidloeffler

  • Authors changed from Martin Albrecht to Martin Albrecht, David Loeffler

comment:10 Changed 9 years ago by malb

  • Reviewers set to Martin Albrecht, David Loeffler
  • Status changed from needs_review to positive_review

Everybody happy

comment:11 Changed 9 years ago by jdemeyer

  • Description modified (diff)

comment:12 Changed 9 years ago by jdemeyer

  • Merged in set to sage-4.8.rc0
  • Resolution set to fixed
  • Status changed from positive_review to closed
Note: See TracTickets for help on using tickets.